Skip to content

Make configfixture meaningful in ProcessCronQueueObserverTest #16253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2018
Merged

Make configfixture meaningful in ProcessCronQueueObserverTest #16253

merged 1 commit into from
Jul 2, 2018

Conversation

evktalo
Copy link
Contributor

@evktalo evktalo commented Jun 19, 2018

Description

Filter test result collection with the cron job code defined in the config fixture. Set the schedule for every minute so that the job is scheduled regardless of the time when you run the test.

Fixed Issues (if relevant)

  1. Integration test ProcessCronQueueObserverTest.php succeeds regardless of magento config fixture #16243

Manual testing scenarios

  1. run dev/tests/integration/testsuite/Magento/Cron/Observer/ProcessCronQueueObserverTest.php

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…onfig fixture. Set the schedule for every minute so that the job is scheduled regardless of the time when you run the test.
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 19, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @evktalo. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
  • @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
  • @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @evktalo. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants