Skip to content

[Forwardport] 6879 - Unable to change country of manufacture default label value #14714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rostyslav-hymon
Copy link
Contributor

Original Pull Request

#14319

Description

This pull request fixes issue with not being able to save dropdown attributes which cannot be edited. I've added following change - while validating if the required value is empty, validation now also checks whether or not it's disabled. The issue occurred with "Country of Manufacture" attribute, which rows can't be edited. In general - it was occurring with all dropdown attributes that had disabled rows with at least one empty value in admin box.

Fixed Issues

  1. Unable to change country of manufacture default label value #6879: Unable to change country of manufacture default label value

Manual testing scenarios

  1. Navigate to product attributes in admin panel
  2. Edit "Country of Manufacure" attribute
  3. Save the attribute
  4. Check if attribute has changes that are supposed to be saved.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @rostyslav-hymon. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants