Skip to content

Invoice grid shows wrong subtotal for partial items invoice. It shows order's subtotal instead if invoiced item's subtotal #13855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2018

Conversation

ankurvr
Copy link
Member

@ankurvr ankurvr commented Feb 27, 2018

Description

Fixed Issues

  1. Invoice grid shows wrong subtotal for partial items invoice. It shows order's subtotal instead if invoiced item's subtotal #13804: Invoice grid shows wrong subtotal for partial items invoice. It shows order's subtotal instead if invoiced item's subtotal

Manual testing scenarios

  1. Place order with multiple taxable items
  2. Generate separate invoice for each items. (In short generate multiple invoices for same order with different items)
  3. Do check value of Subtotal column value in Invoice grid.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Feb 27, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

@ankurvr thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@ankurvr
Copy link
Member Author

ankurvr commented Mar 8, 2018

@sidolov Hey, I am sorry that i moved card to Merging In Progress status. It was by mistake. I have again added into Testing In Progress. This will not happen again in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants