Skip to content

[Forwardport] Add option to add IP address to existing list + add test #13783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2018
Merged

[Forwardport] Add option to add IP address to existing list + add test #13783

merged 1 commit into from
Feb 26, 2018

Conversation

serhii-balko
Copy link
Contributor

@serhii-balko serhii-balko commented Feb 22, 2018 •
edited
Loading

Original pull request

#13586

Description

When adding a new IP-address, you have to copy the existing ones. This adds a --add flag to just append the addresses, instead of replacing

Manual testing scenarios

  1. Set the IP address
  2. Add new ones with --add
  3. See the existing one still on the list

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@miguelbalparda miguelbalparda self-assigned this Feb 22, 2018
@miguelbalparda miguelbalparda self-requested a review February 23, 2018 13:03
@magento-engcom-team magento-engcom-team added this to the February 2018 milestone Feb 23, 2018
@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
MAGETWO-88281 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit aec1858 into magento:2.3-develop Feb 26, 2018
magento-engcom-team pushed a commit that referenced this pull request Feb 26, 2018
MAGETWO-88281: [Forwardport] Add option to add IP address to existing…
6579cd7 
… list + add test #13783
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelbalparda miguelbalparda miguelbalparda approved these changes

Assignees

@miguelbalparda miguelbalparda

Labels
Progress: accept Release Line: 2.3
Projects
None yet
Milestone
February 2018
Development

Successfully merging this pull request may close these issues.
3 participants
@serhii-balko @magento-engcom-team @miguelbalparda