Fix URL passed to static.php in PHP in-development server

[nieltg]

Unresolved static assets are generated by passing some part of URL as resource= parameter to pub/static.php. But PHP in-development server's router, router.php, wrongly passes the parameter.

Instead of frontend/Magento/luma/en_US/images/logo.svg, PHP in-development server's router uses static/frontend/Magento/luma/en_US/images/logo.svg for resource= parameter.

Because of that, resources can't be resolved when Magento runs on PHP in-development server.

Description

This pull request removes static/ string from the resource= parameter, so static.php can generate the specified resource correctly.

This pull request also changes command to start PHP in-development server in the documentation. The previous command in the documentation is:

$ php -S 127.0.0.1:8082 -t ./pub/ ./phpserver/router.php

which results an error because PHP is unable to find router.php.

PHP 7.1.13 Development Server started at Thu Jan 25 19:50:01 2018
Listening on http://127.0.0.1:8082
Document root is /mnt/d/Projects/Magento/magento2/pub
Press Ctrl-C to quit.
[Thu Jan 25 19:50:07 2018] PHP Warning:  Unknown: failed to open stream: No such file or directory in Unknown on line 0
[Thu Jan 25 19:50:07 2018] PHP Fatal error:  Unknown: Failed opening required '/mnt/d/Projects/Magento/magento2/pub/./phpserver/router.php' (include_path='.:') in Unknown on line 0

Manual testing scenarios

1. Get a freshly cloned Magento repository.
2. Run composer install.
3. Setup Magento using php bin/magento setup:install as specified in the documentation.
4. Start PHP in-development server using php -S 127.0.0.1:8082 -t ./pub/ ../phpserver/router.php.

[magento-cicd2]

All committers have signed the CLA.

[miguelbalparda]

This is quite interesting, I'll give it a try tomorrow. Have you seen any reported bugs related to this?

[nieltg]

Thank you @miguelbalparda!
Sorry, I haven't checked any reported bugs yet about this problem.

I've just been trying to run Magento on PHP in-development server and found some issues to be fixed. 😁

[miguelbalparda]

pub and phpserver folders are at the same level, why do you use 2 different paths in php -S 127.0.0.1:8082 -t ./pub/ ../phpserver/router.php?

[miguelbalparda]

I see what you mean now, my bad.

[miguelbalparda]

This seems to be present in 2.2 and 2.1 but removed in f05a32f
Do you remember the reason for the removal @aredridel?

[magento-engcom-team]

@nieltg thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[nieltg]

@magento-engcom-team
Woah, really? Thank you very much.

[aredridel]

@miguelbalparda Removal of what?

[miguelbalparda]

Isn't this you @aredridel?