Skip to content

Fix incorrect @return tag #13356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2018
Merged

Fix incorrect @return tag #13356

merged 1 commit into from
Feb 7, 2018

Conversation

akiojalehto
Copy link
Member

@akiojalehto akiojalehto commented Jan 24, 2018 •
edited
Loading

Description

placeCheckoutOrder method had a @return string in PHPDocs even though it never returns anything.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@okorshenko
Copy link
Contributor

Hi @akiojalehto
It would be great if you can combine such small PRs into bigger batches.
Thank you

@akiojalehto
Copy link
Member Author

Ok, I will keep collecting these in future and make a larger ones.

@oliverklee
Copy link
Contributor

The change looks good to me.

@akiojalehto akiojalehto reopened this Jan 31, 2018
@dmanners dmanners added this to the February 2018 milestone Feb 7, 2018
@magento-engcom-team magento-engcom-team merged commit efe5b63 into magento:2.3-develop Feb 7, 2018
magento-engcom-team pushed a commit that referenced this pull request Feb 7, 2018
@ishakhsuvarov
MAGETWO-87519: Fix incorrect @return tag #13356
408cd32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dmanners dmanners

Labels
Progress: accept Release Line: 2.3
Projects
None yet
Milestone
February 2018
Development

Successfully merging this pull request may close these issues.
5 participants
@akiojalehto @okorshenko @oliverklee @dmanners @magento-engcom-team