Skip to content

Remove redundant code for clarity #13303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2018
Merged

Remove redundant code for clarity #13303

merged 1 commit into from
Jan 31, 2018

Conversation

akiojalehto
Copy link
Member

@akiojalehto akiojalehto commented Jan 21, 2018

Description

$curl->read() will always return a string even if curl_exec fails because there is preg_replace at the end. Because the $data can never be identical to false so I think this redundant piece of code should be removed.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants