Typo cleanup for app #13283
Merged
Typo cleanup for app #13283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishakhsuvarov
approved these changes
Jan 20, 2018
- Suppressed warning for unused formal parameter in constructor so that static tests pass - Marked unused property as deprecated for future removal
|
@akiojalehto Thank you for contribution. Changes look good to me. |
|
@ishakhsuvarov Great, thank you. I noticed that the test result was unrelated to PR, but didn't spot the logic for it. |
orlangur
reviewed
Jan 20, 2018
| @@ -51,7 +51,7 @@ public function setMaxPrice($maxPrice); | |||
|
|
|||
| /** | |||
| * Set max regular price | |||
| * Max regular price is the same, as maximum price, except of excluding calculating special price and catalogules | |||
| * Max regular price is the same, as maximum price, except of excluding calculating special price and catalogues | |||
|
@akiojalehto I took the liberty of updating the doc block with more appropriate wording. Hope you don't mind |
|
@ishakhsuvarov Don't mind at all, it's much faster if you guys update directly all the things you see more appropriate. |
magento-team
pushed a commit
that referenced
this pull request
Jan 22, 2018
This was referenced May 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was adjusting my code inspection and made a little larger cleanup for typos while at it. No breaking changes, just misspellings.
Contribution checklist