Skip to content

[2.3-develop] Remove not used count() from templates + Fix issue with continue in templates 2.3 #13138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 18, 2018
Merged

[2.3-develop] Remove not used count() from templates + Fix issue with continue in templates 2.3 #13138

merged 2 commits into from
Jan 18, 2018

Conversation

ihor-sviziev
Copy link
Contributor

@ihor-sviziev ihor-sviziev commented Jan 11, 2018 •
edited
Loading

Description

Backport of 2 PRs: #12901 + #13076 to 2.3-develop

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

coderimus and others added 2 commits January 11, 2018 16:38
@coderimus @ihor-sviziev
FIX: remove not used count from templates
adbf774 
(cherry picked from commit 35a6ebb)
@ihor-sviziev
Fix issues caused by using continue in loops
70a3f89 
- Fix echoing "continue;" instead of executing it
- Replace continue to opposite condition in if blocks

(cherry picked from commit 2b47c8f)
@ihor-sviziev ihor-sviziev requested a review from orlangur January 11, 2018 14:43
@orlangur orlangur self-assigned this Jan 11, 2018
@orlangur orlangur added this to the January 2018 milestone Jan 11, 2018
@magento-team magento-team merged commit 70a3f89 into magento:2.3-develop Jan 18, 2018
magento-team pushed a commit that referenced this pull request Jan 18, 2018
MAGETWO-86659: [2.3-develop] Remove not used count() from templates +…
c6af7de 
… Fix issue with continue in templates 2.3 #13138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

Labels
Progress: accept Release Line: 2.3
Projects
None yet
Milestone
January 2018
Development

Successfully merging this pull request may close these issues.
4 participants
@ihor-sviziev @orlangur @magento-team @coderimus