Skip to content

[Port 2.3-develop] Respect "Learn More Link" in Recently Viewed Products widget options #12947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2018

Conversation

JeroenVanLeusden
Copy link
Member

@JeroenVanLeusden JeroenVanLeusden commented Jan 2, 2018

Description

Port of #12946. Learn More Link widget option in a Recently Viewed Products widget isn't respecting its setting.

Fixed Issues (if relevant)

  1. None

Manual testing scenarios

  1. Create Recently Viewed Products widget.
  2. In Widget Options > Product attributes to show, enable Name, Image and Price.
  3. On frontend the widget will also display the Learn More Link.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmanners Can you also process this one for 2.3-develop?

@dmanners dmanners self-assigned this Jan 2, 2018
@dmanners
Copy link
Contributor

dmanners commented Jan 2, 2018

@JeroenVanLeusden yup. I will process this also.

@dmanners dmanners added this to the January 2018 milestone Jan 2, 2018
@magento-team magento-team merged commit a77f6c2 into magento:2.3-develop Jan 3, 2018
magento-team pushed a commit that referenced this pull request Jan 3, 2018
@JeroenVanLeusden JeroenVanLeusden deleted the patch-4 branch January 4, 2018 08:47
@paales paales added Partner: Reach Digital Pull Request is created by partner Reach Digital and removed Partner: Reach Digital Pull Request is created by partner Reach Digital labels May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Reach Digital Pull Request is created by partner Reach Digital Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants