Skip to content

Fix import grouped products #12853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 9, 2018
Merged

Fix import grouped products #12853

merged 2 commits into from
Jan 9, 2018

Conversation

PieterCappelle
Copy link
Contributor

@PieterCappelle PieterCappelle commented Dec 21, 2017 •
edited by insanityinside
Loading

As of 2.2, group products no longer import properly. Using the sample data given on the system->import page, it will import the group product (the product type is correct), but no longer associate the simple products to the grouped product. This was confirmed working in 2.1.7, but looks to be broken in 2.2.1 and 2.2.2.

I fixed this for 2.3. If accepted, I'll create backport for 2.2

Fixed Issues (if relevant)

  1. 2.2 Importing Group Products No Longer Works #12793

Manual testing scenarios

  1. Import with sample data is not working

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Dec 21, 2017
@sasilinux
Copy link

@PieterCappelle - Have you ever got a chance to solve this issue. If you found any solution, please let me know. Thanks

@PieterCappelle
Copy link
Contributor Author

@sasilinux This should be fixed. See commit. 01013fa

@sasilinux
Copy link

@PieterCappelle - Yes. It is working for me. Thanks a ton.

@mzeis mzeis self-assigned this Dec 24, 2017
@mzeis
Copy link
Contributor

mzeis commented Dec 24, 2017

Hi @PieterCappelle, thank you for your PR! I will probably process it after the holidays.

@mzeis mzeis added this to the December 2017 milestone Dec 27, 2017
@dmanners dmanners mentioned this pull request Jan 3, 2018
Closed
@okorshenko okorshenko modified the milestones: December 2017, January 2018 Jan 8, 2018
@magento-team magento-team mentioned this pull request Jan 9, 2018
Closed
@magento-team magento-team merged commit b566ca7 into magento:2.3-develop Jan 9, 2018
magento-team pushed a commit that referenced this pull request Jan 9, 2018
@ishakhsuvarov
MAGETWO-86044: Fix import grouped products #12853
9c9f2f3
@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jan 9, 2018
@mzeis
Copy link
Contributor

mzeis commented Jan 9, 2018 •
edited
Loading

Hi @PieterCappelle, thanks again for your PR! It has been merged into 2.3-develop.

@adamlavery
Copy link

When is 2.3 due for release?

@mzeis
Copy link
Contributor

mzeis commented Jan 10, 2018

@adamlavery Sorry, I'm not aware of a planned date for 2.3. Maybe somebody of the core team can chime in.

@yoosefi
Copy link

yoosefi commented Mar 30, 2018

This is absurd. It is only a couple of lines and it's been months. Give us a 2.2 patch already.

@mzeis
Copy link
Contributor

mzeis commented Mar 31, 2018

@yoosefi Everybody can create a PR with a backport to 2.2.

@yoosefi
Copy link

yoosefi commented Apr 2, 2018

@mzeis great idea, how about the person that introduced this regression?

@mzeis
Copy link
Contributor

mzeis commented Apr 3, 2018

@yoosefi I'm afraid that the core team won't backport the fix to 2.2 if that's what you mean. You can use the patch URL functionality by GitHub https://patch-diff.githubusercontent.com/raw/magento/magento2/pull/12853.patch to see if this fixes the problem for you in 2.2. If yes, feel free to use it! If you then want to create a PR against 2.2-develop so other profit from this too, I'm sure you some community members would be very happy you saved them some hassle.

@dmanners dmanners mentioned this pull request May 18, 2018
Merged
4 tasks
@insanityinside insanityinside mentioned this pull request Sep 17, 2018
Merged
magento-engcom-team added a commit that referenced this pull request Sep 24, 2018
@magento-engcom-team
ENGCOM-3003: [Backport] Fix import grouped products #12853 #18097
ef885ce 
 - Merge Pull Request #18097 from getjohn/magento2:2.2-develop
 - Merged commits:
   1. f00ce93
magento-engcom-team pushed a commit that referenced this pull request Sep 24, 2018
ENGCOM-3003: [Backport] Fix import grouped products #12853 #18097
40583b7
magento-engcom-team added a commit that referenced this pull request Sep 24, 2018
@magento-engcom-team
🔃 [EngCom] Public Pull Requests - 2.2-develop
5e7bc50 
Accepted Public Pull Requests:
 - #18126: [Backport] [2.2] Changed intval($val) to (int) $val, since it is faster: (by @dmytro-ch)
 - #18000: Fix sitemap grid render incorrect base urls for multiple stores (by @nntoan)
 - #18098: Fix shipping discount failed to apply during place order (by @torreytsui)
 - #18113: [Backport] Fixes from #15947 (by @ihor-sviziev)
 - #18097: [Backport] Fix import grouped products #12853 (by @insanityinside)
 - #17993: fix #17582 ./bin/magento config:show fails with a fatal error (by @keyurshah070)
 - #17679: Update shipment collection to unserialize `packages` attribute after load (by @dnsv)
 - #18055: fix: reset search mini-form when we have no data / an empty response (by @DanielRuf)
 - #14065: Correctly convert config integration api resources (by @therool)


Fixed GitHub Issues:
 - #17999: Sitemap grid display incorrect base URL in the grid if using multiple stores (reported by @nntoan) has been fixed in #18000 by @nntoan in 2.2-develop branch
   Related commits:
     1. 1172aae

 - #17582: ./bin/magento config:show fails with a fatal error (reported by @simonworkhouse) has been fixed in #17993 by @keyurshah070 in 2.2-develop branch
   Related commits:
     1. ae503f6

 - #12095: Update 2.2.1: One or more integrations have been reset because of a change to their xml configs. (reported by @thomvanderboon) has been fixed in #14065 by @therool in 2.2-develop branch
   Related commits:
     1. 89a0a09
     2. 5815a20
     3. 406935b
     4. 3868e81
     5. 42eab52
@PieterCappelle PieterCappelle deleted the fix_2_3_issue_12793 branch February 5, 2020 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzeis mzeis

Labels
Component: ImportExport Fixed in 2.3.x The issue has been fixed in 2.3 release line Progress: accept Release Line: 2.3 Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
January 2018
Development

Successfully merging this pull request may close these issues.
8 participants
@PieterCappelle @sasilinux @mzeis @adamlavery @yoosefi @magento-team @okorshenko @magento-engcom-team