Skip to content

Fixed incorrect text above billing addresses list #11399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vovayatsyuk
Copy link
Member

Description

This label is not visible at standard checkout, but here are screenshots of how it looks at third-party checkout:

Default Label Correct Label
image image

Manual testing scenarios

  1. Apply some styles to make label visible at standard checkout:

    .checkout-payment-method .field-select-billing > .label {
        clip: auto;
        width: auto;
        height: auto;
    }
  2. Navigate to checkout page as registered customer and proceed to payment method

  3. Uncheck "My billing and shipping address are the same" checkbox and you'll see the address list with the incorrect label.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@okorshenko okorshenko self-assigned this Oct 12, 2017
@okorshenko okorshenko added this to the October 2017 milestone Oct 12, 2017
@magento-team magento-team merged commit aa81f0a into magento:develop Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants