Unable to get product collection scoped `decimal` attribute if price is globally scoped

[gimanik]

Preconditions and environment

• Magento version 2.4.8-p2

Steps to reproduce

Problem is pretty straightforward.

1. Set price as global (it's by default)
2. Add decimal scoped attribute example_decimal_attr
3. Set decimal attribute value on some products on store scope (not global - store_id > 0)
4. Create product collection for scope where created attribute have value (i.e. store_id = 1)
5. Add attributes to select:

$collection->setStoreId(1);
$collection->addAttributeToSelect('example_decimal_attr');
$collection->addAttributeToSelect('price');
$collection->load();

Expected result

Loaded products in collection have example_decimal_attr values.

Actual result

Loaded products in collection does not have example_decimal_attr values. If we remove price from collection attributes select, then it works as expected.
This works:

$collection->setStoreId(1);
$collection->addAttributeToSelect('example_decimal_attr');
$collection->load();

Adding $collection->addAttributeToSelect('price'); before loading collection, causes bug, that example_decimal_attr values are not present.

Additional information

The issue is here:
Magento\Catalog\Model\ResourceModel\Collection\AbstractCollection::_getLoadAttributesSelect
lines 177-179:

                if ($attribute->getAttributeCode() === 'price' && (int)$attribute->getIsGlobal() === 1) {
                    $storeId = $this->getDefaultStoreId();
                }

it replaces $storeId with DefaultStoreId (0 - global) for attribute value select that's for all decimal attributes (not only price).

Without ->addAttributeToSelect('price') returned select looks like this:

SELECT `t_d`.`attribute_id`, `e`.`entity_id` FROM `catalog_product_entity_decimal` AS `t_d`
 INNER JOIN `catalog_product_entity` AS `e` ON e.entity_id = t_d.entity_id
 LEFT JOIN `catalog_product_entity_decimal` AS `t_s` ON t_s.attribute_id = t_d.attribute_id AND t_s.entity_id = t_d.entity_id AND t_s.store_id = 1 WHERE (e.entity_id IN (2, 3)) AND (t_d.attribute_id IN (146)) AND (t_d.store_id = IFNULL(t_s.store_id, 0))

and has correct t_s.store_id = 1 and works as expected.

And if we add ->addAttributeToSelect('price') to collection, returned select looks like this:

SELECT `t_d`.`attribute_id`, `e`.`entity_id` FROM `catalog_product_entity_decimal` AS `t_d`
 INNER JOIN `catalog_product_entity` AS `e` ON e.entity_id = t_d.entity_id
 LEFT JOIN `catalog_product_entity_decimal` AS `t_s` ON t_s.attribute_id = t_d.attribute_id AND t_s.entity_id = t_d.entity_id AND t_s.store_id = 0 WHERE (e.entity_id IN (2, 3)) AND (t_d.attribute_id IN (146, 77)) AND (t_d.store_id = IFNULL(t_s.store_id, 0))

with t_s.store_id = 0 which is wrong, because it wont load any other decimal attribute values that are scoped, or loaded values will be from global scope, even though $collection is for specific store_id.

Correct way to fix it is just to remove
Magento\Catalog\Model\ResourceModel\Collection\AbstractCollection::_getLoadAttributesSelect
lines 171-180:

foreach ($attributeIds as $id) {
    $attribute = $this->_eavConfig->getAttribute(
        $this->getEntity()->getType(),
        $id
    );

    if ($attribute->getAttributeCode() === 'price' && (int)$attribute->getIsGlobal() === 1) {
        $storeId = $this->getDefaultStoreId();
    }
}

Because it's not neccessary
Then it works as expected.
Or check there if all attributes are global: $attribute->getIsGlobal() === 1 not only price.

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @gimanik. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[engcom-Hotel]

Hello @gimanik,

Thank you for the report and collaboration!

We have tried to reproduce the issue in the latest development branch i.e. 2.4-develop but it seems the issue is not reproducible for us. The steps and the screenshot is as follows:

1. Set price as global (it's by default)
2. Add decimal scoped attribute example_decimal_attr

3. Set decimal attribute value on some products on store scope (not global - store_id > 0)

4. Create product collection for scope where created attribute have value (i.e. store_id = 1)

protected function execute(
        InputInterface $input,
        OutputInterface $output
    ): int {
        $name = $input->getArgument(self::NAME_ARGUMENT);
        $option = $input->getOption(self::NAME_OPTION);
        
        $output->writeln("Reproducing Issue #40218 - Product Collection Attribute Bug");
        $output->writeln("========================================================");
        
        // Test Case 1: Working case (without price)
        $collection1 = $this->productCollectionFactory->create();
        $collection1->setStoreId(2); // Use store ID where you set the attribute values
        $collection1->addAttributeToSelect('example_decimal_attr');
        $collection1->load();

        $output->writeln("Collection WITHOUT price attribute:");
        foreach ($collection1 as $product) {
            $output->writeln("Product ID: " . $product->getId() . 
                 " - example_decimal_attr: " . $product->getExampleDecimalAttr());
        }

        // Test Case 2: Bug case (with price)
        $collection2 = $this->productCollectionFactory->create();
        $collection2->setStoreId(2); // Same store ID
        $collection2->addAttributeToSelect('example_decimal_attr');
        $collection2->addAttributeToSelect('price'); // This causes the bug
        $collection2->load();

        $output->writeln("\nCollection WITH price attribute:");
        foreach ($collection2 as $product) {
            $output->writeln("Product ID: " . $product->getId() . 
                 " - example_decimal_attr: " . $product->getExampleDecimalAttr());
        }
        
        return Command::SUCCESS;
    }

For us we are able to get the values for example_decimal_attr with price attribute.

Please let us know if we missed anything.

[gimanik]

@engcom-Hotel
Thanks for taking up the topic.
Attribute cannot be created from Admin Panel, because attributes created there are not decimal type. They are actually varchar (stored in catalog_product_entity_varchar).
You can check backend_type of attribute in eav_attribute table (backend_type column)- it must be decimal.
To create decimal attribute (stored in catalog_product_entity_decimal), it needs to be done programmatically, for example by module Data Patch.
module_dir/Setup/Patch/Data/ExampleDecimalAttr.php
Example attribute that i had issue with:

    public function apply()
    {
        /** @var \Magento\Eav\Setup\EavSetup $eavSetup */
        $eavSetup = $this->eavSetupFactory->create(['setup' => $this->moduleDataSetup]);
        $eavSetup->addAttribute(
            \Magento\Catalog\Model\Product::ENTITY,
            'example_decimal_attr',
            [
                'type' => 'decimal',
                'label' => 'Example Decimal Attr',
                'input' => 'text',
                'required' => false,
                'global' => \Magento\Eav\Model\Entity\Attribute\ScopedAttributeInterface::SCOPE_WEBSITE,
                'visible' => true,
                'filterable' => false,
                'used_in_product_listing' => true,
                'visible_on_front' => true,
                'is_used_in_grid' => false,
                'is_visible_in_grid' => false,
                'is_filterable_in_grid' => false
            ]
        );
    }

[engcom-Hotel]

Hello @gimanik,

Thank you for the information!

The issue is now reproducible for us in the latest 2.4-develop branch. Hence confirming the issue.