Magento 2.4.8 uses dev packages that don't follow semantic versioning

[guvra]

Summary

We can't upgrade to Magento 2.4.8 because the composer.json file includes dev packages that don't follow semantic versioning.

It is conflicting with a 3rd-party package we use for code quality.

Examples

There are two packages with an invalid package version:

        "pdepend/pdepend": "3.x-dev",
        "phpmd/phpmd": "3.x-dev",

Proposed solution

It seems that the latest available versions are not fully compatible with PHP 8.4, i guess it's the reason why a dev branch is used?

If these packages are unmaintained it's probably best to stop using them.

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @guvra. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[hostep]

Good remark.

After some looking around, it seems like the dev versions of those packages were choosen because they are compatible with PHP 8.4 which Magento 2.4.8 supports. And the stable versions of those packages don't support PHP 8.4 yet.
Here are some threads from those 2 packages discussing this:

• Major version 3.0.0 pdepend/pdepend#702
• PHP 8.4 support phpmd/phpmd#1219

So I think Magento was kind of forced to go for these dev requirements, until the developers of those 2 packages can release new stable versions with PHP 8.4 support (so hopefully when Magento 2.4.8-p1 or 2.4.8-p2 gets released in a few months, those 2 packages will have stable versions and Magento can then switch to stable requirements again).

As for installing your own dev packages without conflicts, I'm a fan of using https://github.com/bamarni/composer-bin-plugin for this, which can create namespaces for composer package bundles (one for phpstan, one for php-cs-fixer, one for phpcs, ...) and those will not conflict with the project dependencies themselves. Maybe that's something to try in your case?
(example where I'm using it: https://github.com/baldwin-agency/magento2-module-image-cleanup/tree/v1-develop/vendor-bin)

[m2-assistant]

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

Hello @guvra,

Thanks for the report and collaboration!

Thanks @hostep, for the detailed explanation on this issue!

We are confirming this issue for now.

Thanks

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.adobe.com/browse/AC-14519 is successfully created for this GitHub issue.