Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Updage seletor style in _message.les #39308

Open
5 tasks
m2-assistant bot opened this issue Oct 29, 2024 · 2 comments · May be fixed by #36698
Open
5 tasks

[Issue] Updage seletor style in _message.les #39308

m2-assistant bot opened this issue Oct 29, 2024 · 2 comments · May be fixed by #36698
Labels
Area: Perf/Frontend All tickets related with improving frontend performance. Component: Frontend Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: PR in progress Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@m2-assistant
Copy link

m2-assistant bot commented Oct 29, 2024

This issue is automatically created based on existing pull request: #36698: Updage seletor style in _message.les


Description (*)

Adjustment in the styled element, so that there is no validation break when loading the style in email and in the frontend.

Related Pull Requests

vitinhomorais00/magento2@2.4-develop...vitinhomorais00-patch-1

Manual testing scenarios (*)

  1. Custom theme password reset flow (header and footer)
  2. Receive an email

Questions or comments

A footer and header template was created in a custom theme.
We manually took the styling from the file: lib/web/css/docs/source/_messages.less and included it in the theme.

Doing so always returns the error CSS inlining error: Warning: Uninitialized string offset 5 in /var/www/html/Magento2/vendor/sabberworm/php-css-parser/src/Value/Color.php on line 56 view the email in a provider (gmail, outlook, mailinator, etc).

We found the error in this line of code: @message-custom-icon__background: #green;
The correct one would be @message-custom-icon__background: green;

So, before it was giving an error during the compilation of the inline CSS in the email, when adjusting this styling it worked again.

We noticed that the same instruction exists in the native file and it would be interesting to have its value correct.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added the Priority: P3 May be fixed according to the position in the backlog. label Oct 29, 2024
@m2-assistant m2-assistant bot linked a pull request Oct 29, 2024 that will close this issue
6 tasks
@engcom-Dash engcom-Dash added Area: Frontend Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Component: Frontend labels Oct 29, 2024
@github-jira-sync-bot
Copy link

❌ Something went wrong. Cannot create Jira issue.

@engcom-Dash engcom-Dash added Area: Perf/Frontend All tickets related with improving frontend performance. Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Component: Frontend and removed Area: Frontend Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Perf/Frontend All tickets related with improving frontend performance. Component: Frontend labels Oct 29, 2024
@github-jira-sync-bot
Copy link

❌ Something went wrong. Cannot create Jira issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Perf/Frontend All tickets related with improving frontend performance. Component: Frontend Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: PR in progress Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants