Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Remove a duplicated <severity> tag from MFTF test AdminSetUpWatermarkForSwatchImageTest #38504

Open
4 tasks done
m2-assistant bot opened this issue Mar 8, 2024 · 4 comments · May be fixed by #31862
Open
4 tasks done

[Issue] Remove a duplicated <severity> tag from MFTF test AdminSetUpWatermarkForSwatchImageTest #38504

m2-assistant bot opened this issue Mar 8, 2024 · 4 comments · May be fixed by #31862
Assignees
@denchev
Labels
Area: Test framework Component: Swatches Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@m2-assistant
Copy link

m2-assistant bot commented Mar 8, 2024

This issue is automatically created based on existing pull request: #31862: Remove a duplicated tag from MFTF test AdminSetUpWatermarkForSwatchImageTest

Description (*)

While looking at functional tests provided by Magento I found that one of the tests AdminSetUpWatermarkForSwatchImageTest has two severity tags with the same value = MAJOR. I think only one of them is needed.

Related Pull Requests

I cannot find which pull request added the second one but the commit is bba6a43

The original commit that introduced the test and the first severity tag is 9bea49f

Fixed Issues (if relevant)

No issue is created for this ticket.

Manual testing scenarios (*)

No manual tests are required. This is code refactoring.

Questions or comments

No questions or comments at this point.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: Swatches Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. labels Mar 8, 2024
@m2-assistant m2-assistant bot linked a pull request Mar 8, 2024 that will close this issue
Open
5 tasks
@engcom-Dash engcom-Dash added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Mar 20, 2024
@engcom-November
Copy link
Contributor

Hello @denchev,

Thank you for the report and collaboration!

Verified on 2.4-develop.
The severity tag is repeated twice in AdminSetUpWatermarkForSwatchImageTest test, hence confirmig the issue.

Thank you.

@engcom-November engcom-November self-assigned this Apr 29, 2024
@m2-assistant M2 Assistant
Copy link
Author

m2-assistant bot commented Apr 29, 2024

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-November engcom-November added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Reported on 2.4.x Indicates original Magento version for the Issue report. Area: Test framework labels Apr 29, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-11873 is successfully created for this GitHub issue.

@m2-assistant M2 Assistant
Copy link
Author

m2-assistant bot commented Apr 29, 2024

✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Hotel engcom-Hotel moved this to Pull Request In Progress in Low Priority Backlog Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denchev denchev

Labels
Area: Test framework Component: Swatches Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Milestone
No milestone
4 participants
@denchev @engcom-November @engcom-Dash @github-jira-sync-bot