Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplification: Catalog_Helper_Output processing logic #192

Closed
amenk opened this issue Jan 21, 2013 · 2 comments
Closed

Simplification: Catalog_Helper_Output processing logic #192

amenk opened this issue Jan 21, 2013 · 2 comments

Comments

@amenk
Copy link
Contributor

amenk commented Jan 21, 2013

In https://github.com/magento/magento2/blob/master/app/code/core/Mage/Catalog/Helper/Output.php there is an interesting logic that allows to specify callbacks for processing attributes.

But I feel, that the same purpose can be already served by simple events.

When not adding events like "catalog_helper_output_productAttribute" and "catalog_helper_output_categoryAttribute" which serve as hooks for the events processing ?

@magento-team
Copy link
Contributor

Yeah this is an old piece of code that was intended to be a view helper. But it is non-conventional implementation comparing to other components and should be redesigned. Alexander, we'd appreciate if you contribute a better implementation you suggested.

@magento-team
Copy link
Contributor

Closing due to lack of recent activity

magento-team pushed a commit that referenced this issue Mar 27, 2015
[GoInc] MAGETWO-35078 Code Coverage for Unit Tests build is broken
maksek pushed a commit that referenced this issue Nov 17, 2015
[Firedrakes && South && WebDev] Bugfixes
mmansoor-magento pushed a commit that referenced this issue Aug 1, 2016
magento-engcom-team added a commit that referenced this issue Nov 19, 2018
 - Merge Pull Request magento/graphql-ce#192 from magento/graphql-ce:graph-ql-shipping-address-coverage
 - Merged commits:
   1. e327bb6
   2. ef8f126
   3. a0bb0fc
   4. c8dbdf4
   5. bf0aaad
   6. 0a6c0b5
   7. 90831f5
   8. 5d2b1c8
   9. e1f09fb
   10. 55b6f4e
   11. 7c21b3b
   12. 2644b54
   13. c857857
   14. 240cfb3
   15. afd128e
   16. d6f393a
   17. 2b5c1aa
   18. 313544e
   19. 4694c06
   20. c498773
   21. 39225d4
taskula pushed a commit to Hypernova-Oy/magento2 that referenced this issue Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants