Skip to content

Wishlist icon cut on Shopping cart page in mobile view #17851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hitesh-wagento opened this issue Aug 29, 2018 · 8 comments
Closed

Wishlist icon cut on Shopping cart page in mobile view #17851

hitesh-wagento opened this issue Aug 29, 2018 · 8 comments
Assignees
@hitesh-wagento
Labels
Area: Design/Frontend Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@hitesh-wagento
Copy link
Contributor

Summary

Wishlist icon cut on Shopping cart page in mobile view.

Preconditions

  1. Magento 2x - This issue reproduce in all version.

Steps to reproduce

  1. Login in your frontend.
  2. Add any product in Cart.
  3. Go to Shopping cart.
  4. Switch mobile view.

Expected result

  1. Wishlist icon should not cut in mobile view.

Actual result

  1. Wishlist icon cut in mobile view.

wishlist-icon
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Aug 29, 2018 •
edited by osrecio
Loading

Hi @hitesh-wagento. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me {$VERSION} instance

where {$VERSION} is version tags (starting from 2.2.0+) or develop branches (2.2-develop +).
For more details, please, review the Magento Contributor Assistant documentation.

@hitesh-wagento do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Aug 29, 2018
@hitesh-wagento
Copy link
Contributor Author

I am working on this issue.

@hitesh-wagento hitesh-wagento self-assigned this Aug 29, 2018
@engcom-backlog-nickolas engcom-backlog-nickolas added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Area: Design/Frontend labels Aug 29, 2018
@engcom-backlog-nickolas engcom-backlog-nickolas removed their assignment Aug 29, 2018
@hitesh-wagento hitesh-wagento mentioned this issue Aug 29, 2018
Closed
@osrecio
Copy link
Member

osrecio commented Aug 29, 2018

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @osrecio. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @osrecio, here is your Magento instance.
Admin access: https://i-17851-2-2-develop.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

osrecio pushed a commit to hitesh-wagento/magento2 that referenced this issue Aug 31, 2018
@hitesh-wagento @osrecio
[Resolved: Wishlist icon cut on Shopping cart page in mobile view mag…
ee67419 
…ento#17851]
hitesh-wagento added a commit to hitesh-wagento/magento2 that referenced this issue Aug 31, 2018
@hitesh-wagento
[Resolved: Wishlist icon cut on Shopping cart page in mobile view mag…
2139fec 
…ento#17851]
@hitesh-wagento hitesh-wagento mentioned this issue Aug 31, 2018
Merged
@sidolov
Copy link
Contributor

sidolov commented Sep 4, 2018

Hi @hitesh-wagento. Thank you for your report.
The issue has been fixed in #17877 by @hitesh-wagento in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.7 release.

@sidolov sidolov added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Sep 4, 2018
@sidolov sidolov closed this as completed Sep 4, 2018
magento-engcom-team added a commit that referenced this issue Sep 4, 2018
@magento-engcom-team
ENGCOM-2901: Resolved : Wishlist icon cut on Shopping cart page in mo…
1017d2b 
…bile view #17851 #17877

 - Merge Pull Request #17877 from hitesh-wagento/magento2:wishlist-icon-cut-new
 - Merged commits:
   1. 2139fec
magento-engcom-team pushed a commit that referenced this issue Sep 4, 2018
ENGCOM-2901: Resolved : Wishlist icon cut on Shopping cart page in mo…
7c00de3 
…bile view #17851 #17877
@hitesh-wagento hitesh-wagento mentioned this issue Sep 4, 2018
Merged
This was referenced Sep 4, 2018
Merged
Merged
hitesh-wagento added a commit to hitesh-wagento/magento2 that referenced this issue Sep 4, 2018
@hitesh-wagento
Merge pull request #28 from hitesh-wagento/2.1-develop-PR-port-17877
2d05fbe 
[Backport] Resolved : Wishlist icon cut on Shopping cart page in mobile view magento#17851
@hitesh-wagento hitesh-wagento mentioned this issue Sep 4, 2018
Merged
@sidolov
Copy link
Contributor

sidolov commented Sep 5, 2018

Hi @hitesh-wagento. Thank you for your report.
The issue has been fixed in #17912 by @hitesh-wagento in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.16 release.

@sidolov sidolov added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label Sep 5, 2018
magento-engcom-team added a commit that referenced this issue Sep 5, 2018
@magento-engcom-team
ENGCOM-2917: [Backport] Resolved : Wishlist icon cut on Shopping cart…
cc92bb5 
… page in mobile view #17851 #28 #17912

 - Merge Pull Request #17912 from hitesh-wagento/magento2:2.1-develop-PR-port-17877
 - Merged commits:
   1. 9cc8481
magento-engcom-team pushed a commit that referenced this issue Sep 5, 2018
ENGCOM-2917: [Backport] Resolved : Wishlist icon cut on Shopping cart…
11d6c73 
… page in mobile view #17851 #28 #17912
@ishakhsuvarov
Copy link
Contributor

Hi @hitesh-wagento. Thank you for your report.
The issue has been fixed in #17911 by @hitesh-wagento in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@ishakhsuvarov ishakhsuvarov added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Sep 11, 2018
magento-engcom-team added a commit that referenced this issue Sep 11, 2018
@magento-engcom-team
ENGCOM-2918: [Forwardport] Resolved : Wishlist icon cut on Shopping c…
3f4febf 
…art page in mobile view #17851 #27 #17911

 - Merge Pull Request #17911 from hitesh-wagento/magento2:2.3-develop-PR-port-17877
 - Merged commits:
   1. f0b5ecc
magento-engcom-team pushed a commit that referenced this issue Sep 11, 2018
ENGCOM-2918: [Forwardport] Resolved : Wishlist icon cut on Shopping c…
308fa83 
…art page in mobile view #17851 #27 #17911
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hitesh-wagento hitesh-wagento

Labels
Area: Design/Frontend Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@osrecio @ishakhsuvarov @sidolov @hitesh-wagento @magento-engcom-team @engcom-backlog-nickolas