Skip to content

Issue in product title with special chars in mini cart #13652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Sunil-Nethues opened this issue Feb 14, 2018 · 15 comments
Closed

Issue in product title with special chars in mini cart #13652

Sunil-Nethues opened this issue Feb 14, 2018 · 15 comments
Labels
Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release

Comments

@Sunil-Nethues
Copy link

Preconditions

  1. Magento 2.2.2 version
  2. Php version 7, Linux
  3. default Luma theme

Steps to reproduce

  1. create a product titled Fusion Backpack ™
  2. go to front end the product title comes up correctly as Fusion Backpack ™ then add it to cart
  3. in the mini cart it shows it as Fusion Backpack ™ and not converting ™ to ™

Expected result

  1. Mini cart should also show the correct product title after converting the html equivalent to characters

Actual result

  1. errr
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Feb 14, 2018
@magento-engcom-team
Copy link
Contributor

@Sunil-Nethues , thank you for your report.
We were not able to reproduce this issue by following the steps you provided. Please provide more detailed steps to reproduce or try to reproduce this issue on a clean installation without any extensions if you have.

product_name_01281280980

@Sunil-Nethues
Copy link
Author

Hello @magento-engcom-team , i have a fresh installation of v 2.2.2

The site can be seen at http://magento6.newsoftdemo.info/m22.2.2/fusion-backpack.html

@magento-engcom-team
Copy link
Contributor

@Sunil-Nethues , thanks for you update. We cannot reproduce this issue with sample data too.

backpack

@ananth-iyer
Copy link
Member

@Sunil-Nethues
Please let us know how you installed Magento 2.2.2
Using zip file or composer install

I've also reproduced the issue but didn't find the issue with sample data on fresh composer install.

@Sunil-Nethues
Copy link
Author

@Ananth747 i have installed the magento2.2.2 using composer. then installed sample data using composer as well. After that i went to admin and changed the product name from Fusion Backpack to Fusion Backpack &trade and then tried to add it in cart. where i saw the issue.

@magento-engcom-team magento-engcom-team added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed and removed Progress: needs update labels Feb 19, 2018
@magento-engcom-team
Copy link
Contributor

@Sunil-Nethues, thank you for your report.
We've acknowledged the issue and added to our backlog.

@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release labels Feb 19, 2018
@mrkhoa99
Copy link
Contributor

@Sunil-Nethues this is because Magento just shows the product name as a plain text, not a HTML. But, I ask myself it makes sense if allowing HTML in the product name?

@magento-engcom-team
Copy link
Contributor

Hi @Sunil-Nethues. Thank you for your report.
The issue has been fixed in #13802 by @afirlejczyk in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Mar 14, 2018
magento-engcom-team added a commit that referenced this issue Mar 14, 2018
…pecial chars. #13802

 - Merge Pull Request #13802 from afirlejczyk/magento2:fix/product-title-in-minicart
 - Merged commits:
   1. 764f086
@saravananvelu
Copy link
Contributor

saravananvelu commented Apr 12, 2018

The same issue I could get reproduced in cart summary section of checkout page. To fix that need to update
vendor\magento\module-checkout\view\frontend\web\template\summary\item\details.html

Use:
<strong class="product-item-name" data-bind="html: $parent.name"></strong>

instead

<strong class="product-item-name" data-bind="text: $parent.name"></strong>

@magento-engcom-team
Copy link
Contributor

Hi @Sunil-Nethues. Thank you for your report.
The issue has been fixed in #14665 by @ampulos in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.15 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label Apr 13, 2018
@magento-engcom-team
Copy link
Contributor

Hi @Sunil-Nethues. Thank you for your report.
The issue has been fixed in #14681 by @ihor-sviziev in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.5 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Apr 14, 2018
magento-engcom-team added a commit that referenced this issue Apr 14, 2018
…title with special chars. #14681

 - Merge Pull Request #14681 from ihor-sviziev/magento2:2.2-develop-PR-port-13802
 - Merged commits:
   1. 8a30ffd
magento-engcom-team pushed a commit that referenced this issue Apr 14, 2018
@geoffbeaumont
Copy link

It looks to me like the fix only works for products with links? The knockout.js type on the non-link product title also needs changing to html.

@InternetMedicineMan
Copy link

I'm running 2.2.7 and this problem has always occurred for us. It was never fixed in 2.2.5

@ihor-sviziev
Copy link
Contributor

Hi @InternetMedicineMan,
Could you report separate issues for that?
Thank you!

@j-lloyd-slc
Copy link

For anyone having this issue in later versions, make sure that you don't have an extension that is re-introducing the problem. E.g. Aitoc PreOrders v2.2.0 re-introduced the issue via its own version of

view/frontend/web/template/minicart/item/default.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release
Projects
None yet
Development

No branches or pull requests

9 participants