Skip to content

Tracking link returns 404 page in admin panel #12206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
catstantin opened this issue Nov 13, 2017 · 7 comments
Closed

Tracking link returns 404 page in admin panel #12206

catstantin opened this issue Nov 13, 2017 · 7 comments
Assignees
@ihor-sviziev
Labels
Component: Shipping Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@catstantin
Copy link

catstantin commented Nov 13, 2017 •
edited
Loading

Preconditions

Magento ver. 2.1.9

Steps to reproduce

  1. Configure Custom URL for admin panel in Admin > Stores > Configuration > Advanced
    admin
  1. Make order
  2. Login to admin panel
  3. Add shipment to order
  4. Click on "Track Order" link on order page in admin panel

Expected result

  1. Url should be generated for store where order was placed

Actual result

  1. Url generated for admin URL, as result - we have 404 page
@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed labels Nov 13, 2017
@magento-engcom-team
Copy link
Contributor

@catstantin, thank you for your report.
We've created internal ticket(s) MAGETWO-83474 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 13, 2017
@p-bystritsky p-bystritsky self-assigned this Nov 14, 2017
@ihor-sviziev
Copy link
Contributor

@p-bystritsky FYI I have fix for this issue, in progress of preparing PR for it

@p-bystritsky
Copy link
Contributor

@ihor-sviziev I'll reassign issue to you.

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Nov 14, 2017 •
edited
Loading

@okorshenko @p-bystritsky FYI we fixed this issue for own project with 9f7171a but I'm not sure that it's really good solution.
It looks like issue it located in getUrl method for $store object, not sure it will be easy fix and not to brake websites. What do you think about this change?

ihor-sviziev added a commit to ihor-sviziev/magento2 that referenced this issue Dec 15, 2017
@ihor-sviziev
magento#12206: Tracking link returns 404 page in admin panel
ecf27be
@ihor-sviziev ihor-sviziev mentioned this issue Dec 15, 2017
Merged
4 tasks
@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Dec 15, 2017 •
edited
Loading

Ok, I tried that fix, it didn't worked well.
I'm working on it at #mageconf

ihor-sviziev added a commit to ihor-sviziev/magento2 that referenced this issue Dec 15, 2017
@ihor-sviziev
magento#12206: Tracking link returns 404 page in admin panel
5e4bf42 
Cover changes with integration test
@okorshenko
Copy link
Contributor

Hi @catstantin. Thank you for your report.
The issue has been fixed in #12732 by @ihor-sviziev in 2.2-develop branch
Related commits:

The fix will be available with the upcoming patch release.

@okorshenko okorshenko added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Dec 22, 2017
@magento-engcom-team
Copy link
Contributor

Hi @catstantin. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1297 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming patch release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jan 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ihor-sviziev ihor-sviziev

Labels
Component: Shipping Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ihor-sviziev @okorshenko @catstantin @p-bystritsky @magento-engcom-team