Magento 2.2 language switching not working on catalog and Product Pages #11963

Yan-Studio-WEB · 2017-11-02T14:33:55Z

Preconditions

Magento Clean Install 2.2
More than one store views English and Greek

Steps to reproduce

got o this page: https://www.nuovamoda.fashion/el/papoutsia/mpotes.html
Try To change Language

Expected result

Go to desired Language

Actual result

Stay in the same Language

mhauri · 2017-11-02T20:42:45Z

Tested it on a clean Magento 2.2 installation with another store view configured and "Add Store Code to Urls" enabled. It works fine in "development" mode, but doesn't work in "production" mode.

Yan-Studio-WEB · 2017-11-03T18:43:15Z

Hi Mhauri
Thanks for your Response and your time
Is it Possible to be fixed?
Thanks In Advance

magento-engcom-team · 2017-11-06T15:07:09Z

Hello @iWEBproject. Thanks for reporting. Would You please provide us detailed steps of how You set two store views.

Yan-Studio-WEB · 2017-11-06T16:32:50Z

Hello
Yes of course I will try to describe

I upload compressed file el_GR.zip and Unzip in to this path: app/i18n/mageplaza/el_GR/
I Flush Magento Cache
I set up the store Views For English and Greek (I set up Greek as default) See Images also
I change URL Options (was not working Corrct before I do That) see image
I Flush Magento Cache
I duplicate blogs and pages for both languages
Done

magento-engcom-team · 2017-11-09T14:58:00Z

@iWEBproject, thank you for your report.
We've created internal ticket(s) MAGETWO-83549 to track progress on the issue.

king-themes · 2017-11-11T15:00:56Z

The same problem here in fresh install of 2.2.1 with Stores > Configuration > Web > Url Options > Add Store Code to Urls = Yes.

ghost · 2017-11-18T14:44:02Z

I have the same issue with 2.2.1 version.

Hope a solution.

ghost · 2017-11-19T17:01:13Z

I see that the issue is fixed on you website https://www.nuovamoda.fashion/el/papoutsia/mpotes.html. How can i fix it please?

thank you in advance.

Yan-Studio-WEB · 2017-11-19T17:55:03Z

Hi achatpc
Is not fixed my friend I wish....
go and check: https://www.nuovamoda.fashion/el/papoutsia/mpotes

ferret-e · 2017-11-25T12:46:26Z

The same in 2.2.1, buth in production and developer modes.

klimart · 2017-12-15T22:10:36Z

The issue occurs in these places:

vendor/magento/module-catalog/Controller/Category/View.php
	public function execute()
	155: if ($this->_request->getParam(\Magento\Framework\App\ActionInterface::PARAM_NAME_URL_ENCODED))

vendor/magento/module-catalog/Controller/Product/View.php
	public function execute()
	79: if ($this->getRequest()->isPost() && $this->getRequest()->getParam(self::PARAM_NAME_URL_ENCODED))

Not completely sure if it should be the correct fix, but additional condition like && !$this->getRequest()->getParam('___from_store') can resolve this issue

vendor/magento/module-catalog/Controller/Category/View.php
	public function execute()
	155: if ($this->_request->getParam(\Magento\Framework\App\ActionInterface::PARAM_NAME_URL_ENCODED) && !$this->_request->getParam('___from_store')) {

vendor/magento/module-catalog/Controller/Product/View.php
	public function execute()
	79: if ($this->getRequest()->isPost() && $this->getRequest()->getParam(self::PARAM_NAME_URL_ENCODED) && !$this->getRequest()->getParam('___from_store')) {

ghost · 2017-12-16T00:56:57Z

Thank you I will test it and provide feedback for you. Have a nice day Envoyé de mon iPhone

…

Le 15 déc. 2017 à 23:11, Artem Klimov ***@***.***> a écrit : The issue occurs in these places: vendor/magento/module-catalog/Controller/Category/View.php public function execute() 155: if ($this->_request->getParam(\Magento\Framework\App\ActionInterface::PARAM_NAME_URL_ENCODED)) vendor/magento/module-catalog/Controller/Product/View.php public function execute() 79: if ($this->getRequest()->isPost() && $this->getRequest()->getParam(self::PARAM_NAME_URL_ENCODED)) Not completely sure if it should be the correct fix, but additional condition like && !$this->getRequest()->getParam('___from_store') can resolve this issue vendor/magento/module-catalog/Controller/Category/View.php public function execute() 155: if ($this->_request->getParam(\Magento\Framework\App\ActionInterface::PARAM_NAME_URL_ENCODED) && !$this->_request->getParam('___from_store')) { vendor/magento/module-catalog/Controller/Product/View.php public function execute() 79: if ($this->getRequest()->isPost() && $this->getRequest()->getParam(self::PARAM_NAME_URL_ENCODED) && !$this->getRequest()->getParam('___from_store')) { — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

irfanMukhtar · 2017-12-28T06:56:42Z

hi @klimart thanks for the solution. i have implemented your solution in my magento 2.2.1 and it is not working. i have tested this solution on "default", "developer" and "production" mode as well.
@p-bystritsky hi, do you have any update regarding this issue ? thanks

klimart · 2017-12-28T08:32:59Z

Hello @irfanMukhtar it's seems strange, as for me fix works in 2.2.2 version, but I don't observe any core code changes in these files from 2.2.0 version, so it should work for 2.2.1 and 2.2.0 too.
I've created git patch for this issue with my changes
https://github.com/klimart/magento2-patches/blob/master/patches/11963-language-issue.patch

irfanMukhtar · 2018-01-02T13:09:18Z

Thanks a lot @klimart. I have implemented you patch in my magento 2.2 and it is working fine. Now language is switching on catalog and product page. Great work 👍

p-bystritsky · 2018-01-02T14:04:23Z

Can also confirm it works fine on 2.2-develop branch.

moleculech · 2018-01-03T15:39:58Z

Maybe this helps someone...
We needed to add an extra parameter (___store) to the fix from @klimart to make it work (in 2.2.1)
/home/www/nahrin/htdocs/vendor/magento/module-catalog/Controller/Product/View.php: Line 79

if ($this->getRequest()->isPost() && $this->getRequest()->getParam(self::PARAM_NAME_URL_ENCODED) && !$this->getRequest()->getparam('___store')) {

/home/www/nahrin/htdocs/vendor/magento/module-catalog/Controller/Category/View.php: Line 155

if ($this->_request->getParam(\Magento\Framework\App\ActionInterface::PARAM_NAME_URL_ENCODED) && !$this->getRequest()->getparam('___store')) {

Yan-Studio-WEB · 2018-01-09T10:12:47Z

Hi klimart and Happy New Year
I just Modify both View.php in the paths you described
Result Product Page Is working
Category Page is not working
Version Of Magento is Clean 2.2.2
https://www.nuovamoda.fashion/el/gynaikeia-papoutsia/mpotes.html

ferret-e · 2018-01-20T12:54:45Z

2.2.2, the same. Applied klimart's patch but language not switched - page simply reloading to the same lang when "Add Store Code to Urls" is on.

pfandrade · 2018-01-25T12:10:35Z

I also confirm the @klimart patch is working on 2.2.2. Thanks!

SherifElfadaly · 2018-01-28T15:06:14Z

@moleculech Tested with 2.2.1 and working fine in category and product put not working in catalog search result.

koenner01 · 2018-02-09T10:19:04Z

I can also confirm this is a problem in 2.1.11
Will try the suggested fix from above

blizam · 2018-02-11T21:32:56Z

I can confirm the issue in 2.2.2 and also that the fix posted by @klimart and in the 13534 pr resolves the issue. I didn't test catalog search results prior to patching my site but I am able to use the language switcher properly on catalog search results (as well as category pages and product detail pages) after the patch.

I really hope this makes it into 2.2.3 as it's a "big deal" IMO :)

//anyone not successful with the patch here probably just needs to flush their caches/static-view/preprocessed files

magento-engcom-team · 2018-02-15T20:55:08Z

Hi @iWEBproject. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1143 by @p-bystritsky in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.4 release.

bobemoe · 2018-04-04T11:00:29Z

I can confirm the same issue on 2.1.12 and that the fix provided by #11963 (comment) has fixed the issue.

Is there a backport planned for 2.1? Or another ticket tracking this?

simonrl · 2018-08-21T16:08:51Z

Hi, it seems to me that the above mentioned fix by @klimart does only work with products and categories that have the same URL key in both stores.
Did anyone get it working with different url keys?

Update

Maybe worth noting:
Magento\Store\Block\Switcher::getTargetStorePostData()
changing getCurrentUrl(false) to getCurrentUrl(true) did the trick for me and now adds nice rewritten URLs to the language switcher. The patch above is not required for this solution. One problem may be that it adds "___from_store=xx" to catalogsearch-URLs, presumably because they don't have a rewrite. Magento v 2.1.14

PieterCappelle · 2018-09-08T13:22:09Z

Hi, has this been backported to 2.1 already?

ste88 · 2018-11-28T14:44:45Z

Hi, I've created a backport for magento 2.1
Patch-Magento_Catalog-MAGETWO-83549-11963-Magento-2.1-language-switching.patch

magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Nov 2, 2017

magento-engcom-team added the Progress: needs update label Nov 6, 2017

Yan-Studio-WEB closed this as completed Nov 6, 2017

magento-engcom-team reopened this Nov 9, 2017

andy17612 mentioned this issue Nov 28, 2017

In magento 2.2 Changing language twice gives error [bug] #11379

Closed

okorshenko removed 2.2.x labels Dec 14, 2017

p-bystritsky removed the Progress: needs update label Dec 22, 2017

p-bystritsky self-assigned this Dec 22, 2017

thomasdom mentioned this issue Feb 7, 2018

Fixed store view switcher issues when changing store view on product ... #13534

Closed

4 tasks

magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Feb 15, 2018

magento-engcom-team closed this as completed Feb 15, 2018

LouNik1984 mentioned this issue Jun 19, 2018

language switcher stopped working olegkoval/magento2-regenerate_url_rewrites#20

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Magento 2.2 language switching not working on catalog and Product Pages #11963

Magento 2.2 language switching not working on catalog and Product Pages #11963

Yan-Studio-WEB commented Nov 2, 2017

mhauri commented Nov 2, 2017 •

edited

Loading

Yan-Studio-WEB commented Nov 3, 2017 •

edited

Loading

magento-engcom-team commented Nov 6, 2017

Yan-Studio-WEB commented Nov 6, 2017

magento-engcom-team commented Nov 9, 2017

king-themes commented Nov 11, 2017 •

edited

Loading

ghost commented Nov 18, 2017

ghost commented Nov 19, 2017

Yan-Studio-WEB commented Nov 19, 2017

ferret-e commented Nov 25, 2017

klimart commented Dec 15, 2017

ghost commented Dec 16, 2017 via email

irfanMukhtar commented Dec 28, 2017

klimart commented Dec 28, 2017

irfanMukhtar commented Jan 2, 2018

p-bystritsky commented Jan 2, 2018

moleculech commented Jan 3, 2018

Yan-Studio-WEB commented Jan 9, 2018 •

edited

Loading

ferret-e commented Jan 20, 2018 •

edited

Loading

pfandrade commented Jan 25, 2018

SherifElfadaly commented Jan 28, 2018

koenner01 commented Feb 9, 2018

blizam commented Feb 11, 2018 •

edited

Loading

magento-engcom-team commented Feb 15, 2018 •

edited by okorshenko

Loading

bobemoe commented Apr 4, 2018

simonrl commented Aug 21, 2018 •

edited

Loading

PieterCappelle commented Sep 8, 2018

ste88 commented Nov 28, 2018

Magento 2.2 language switching not working on catalog and Product Pages #11963

Magento 2.2 language switching not working on catalog and Product Pages #11963

Comments

Yan-Studio-WEB commented Nov 2, 2017

Preconditions

Steps to reproduce

Expected result

Actual result

mhauri commented Nov 2, 2017 • edited Loading

Yan-Studio-WEB commented Nov 3, 2017 • edited Loading

magento-engcom-team commented Nov 6, 2017

Yan-Studio-WEB commented Nov 6, 2017

magento-engcom-team commented Nov 9, 2017

king-themes commented Nov 11, 2017 • edited Loading

ghost commented Nov 18, 2017

ghost commented Nov 19, 2017

Yan-Studio-WEB commented Nov 19, 2017

ferret-e commented Nov 25, 2017

klimart commented Dec 15, 2017

ghost commented Dec 16, 2017 via email

irfanMukhtar commented Dec 28, 2017

klimart commented Dec 28, 2017

irfanMukhtar commented Jan 2, 2018

p-bystritsky commented Jan 2, 2018

moleculech commented Jan 3, 2018

Yan-Studio-WEB commented Jan 9, 2018 • edited Loading

ferret-e commented Jan 20, 2018 • edited Loading

pfandrade commented Jan 25, 2018

SherifElfadaly commented Jan 28, 2018

koenner01 commented Feb 9, 2018

blizam commented Feb 11, 2018 • edited Loading

magento-engcom-team commented Feb 15, 2018 • edited by okorshenko Loading

bobemoe commented Apr 4, 2018

simonrl commented Aug 21, 2018 • edited Loading

PieterCappelle commented Sep 8, 2018

ste88 commented Nov 28, 2018

mhauri commented Nov 2, 2017 •

edited

Loading

Yan-Studio-WEB commented Nov 3, 2017 •

edited

Loading

king-themes commented Nov 11, 2017 •

edited

Loading

Yan-Studio-WEB commented Jan 9, 2018 •

edited

Loading

ferret-e commented Jan 20, 2018 •

edited

Loading

blizam commented Feb 11, 2018 •

edited

Loading

magento-engcom-team commented Feb 15, 2018 •

edited by okorshenko

Loading

simonrl commented Aug 21, 2018 •

edited

Loading