Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wysywig editor shows broken image icons #10417

Closed
deadlyw1re opened this issue Aug 3, 2017 · 17 comments
Closed

Wysywig editor shows broken image icons #10417

deadlyw1re opened this issue Aug 3, 2017 · 17 comments
Assignees
@PieterCappelle
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@deadlyw1re
Copy link

Preconditions

  1. Magento 2.1.7
  2. PHP 7.0

Steps to reproduce

  1. Add image in Wysywig editor

Expected result

  1. Image is shown in editor

Actual result

  1. Broken image icon
  2. Url is <img src="http://domain/path-to-magento/adminurl/cms/wysiwyg/directive/___directive/e3ttZWRpYSB1cmw9Ind5c2l3eWcvcGRmL3BkZi5wbmcifX0,/key/e44fd2b2430f15239de43de5a10cb958615b525bb7bca920ab2865c99ff7de7d/" data-mce-src="http://domain/path-to-magento/adminurl/cms/wysiwyg/directive/___directive/e3ttZWRpYSB1cmw9Ind5c2l3eWcvcGRmL3BkZi5wbmcifX0,/key/e44fd2b2430f15239de43de5a10cb958615b525bb7bca920ab2865c99ff7de7d/">
@hostep
Copy link
Contributor

hostep commented Aug 3, 2017 •
edited
Loading

If this occurs on the product or category wysiwyg fields, then it is probably a duplicate of #6138, and this bug will be fixed in Magento 2.1.8: ba66124

@deadlyw1re
Copy link
Author

@hostep This occures in the wysiwyg editor itself, on the frontend the images are visible.

@hostep
Copy link
Contributor

hostep commented Aug 3, 2017

@deadlyw1re: Yes, but which wysiwyg editor? The one in the CMS pages/blocks shouldn't have this bug, only the wysiwyg editor on the product and categories edit forms if I remember correctly.

@deadlyw1re
Copy link
Author

deadlyw1re commented Aug 8, 2017 •
edited
Loading

@hostep This bug occures on CMS pages/blocks and products/categories

@magento-engcom-team magento-engcom-team added G1 Passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed G1 Passed labels Sep 5, 2017
@PieterCappelle
Copy link
Contributor

@hostep I think the bug is back in 2.1.9. We are having the same problem in CMS Pages / Blocks. When you insert image in 2.1.8, we get <p><img src="{{media url="wysiwyg/Hond.jpg"}}" width="1024" height="683" /></p> when we insert image in 2.1.9 <p><img src="http://local.magento/admin/cms/wysiwyg/directive/___directive/e3ttZWRpYSB1cmw9Ind5c2l3eWcvVmVsZC5qcGcifX0%2C/key/d3f89696a93152f6d352e5d5cb391180a27c8a7924d9fe3b583d3e9f03d00753/" width="959" height="1024" /></p>

@hostep
Copy link
Contributor

hostep commented Sep 25, 2017

@PieterCappelle: that's weird, I can't really see anything at first sight in the diff between 2.1.8 and 2.1.9 which can cause this bug to re-appear.

Can you reproduce it on a clean 2.1.9 installation?

@PieterCappelle
Copy link
Contributor

@hostep Tomorrow at MM17BE? Will show you my case.

@hostep
Copy link
Contributor

hostep commented Sep 25, 2017

Confirmed, tried it on a clean 2.1.8: no problem
Then on a clean 2.1.9: and the problem you describe appears. God damned, I hoped we were finally rid of this bug, but it came back :(

(See you tomorrow at MM17BE :))

@PieterCappelle
Copy link
Contributor

You should join the Slack channel of Magento. Let's fix this in the contribution day :-)

@okorshenko
Copy link
Contributor

Just for info: 2.1.8...2.1.9#diff-92c32b12996a53a237ff51fa0d39d829R113

@PieterCappelle PieterCappelle mentioned this issue Sep 26, 2017
Merged
4 tasks
@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Sep 27, 2017
@magento-engcom-team
Copy link
Contributor

@deadlyw1re, thank you for your report.
We were not able to reproduce this issue by following the steps you provided. If you'd like to update it, please reopen the issue.

@magento-engcom-team magento-engcom-team added the Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch label Sep 27, 2017
This was referenced Oct 2, 2017
Closed
Closed
okorshenko pushed a commit that referenced this issue Oct 4, 2017
@vrann
MAGETWO-80230: Fix #10417 #11048
9c21120 
 - Merge Pull Request #11048 from PieterCappelle/magento2:fix_wysiwyg
 - Merged commits:
   1. c3ea1f5
   2. 0c0393d
   3. 6237877
   4. 202dd82
okorshenko pushed a commit that referenced this issue Oct 4, 2017
@vrann
MAGETWO-80230: Fix #10417 #11048
097ca09
@okorshenko okorshenko added Fixed in 2.2.x The issue has been fixed in 2.2 release line and removed Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch labels Oct 4, 2017
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-80230

@magento-team magento-team added 2.2.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Oct 4, 2017
@PieterCappelle PieterCappelle mentioned this issue Oct 9, 2017
Merged
4 tasks
magento-team pushed a commit that referenced this issue Oct 12, 2017
MAGETWO-81305: [2.1-Develop] Fix #10417 #11309
700f191 
 - Merge Pull Request #11309 from PieterCappelle/magento2:fix_2_1_issue_10417
 - Merged commits:
   1. 94dc250
   2. e175b7a
magento-team pushed a commit that referenced this issue Oct 12, 2017
MAGETWO-81305: [2.1-Develop] Fix #10417 #11309
8c564ca
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-81305

@LSERRE
Copy link

LSERRE commented Oct 16, 2017

I have the same issue on 2.2.0.

@WalterSmulders
Copy link

WalterSmulders commented Nov 6, 2017 •
edited
Loading

I experienced the same issue today and it kept me busy for a half day, but I found that at least my problem was not related to the Magento code.

One of the external extensions had a extra empty line at the beginning of the registration.php. This extra empty line was added at the beginning of the response. Which in turn made the browser not recognising the image and thus not showing it since it doesn't start with the required bytes.

I could find the registration.php that was responsible for this error by debugging trough app/etc/NonComposerComponentRegistration.php simply put a echo $file; after include $file; if you see that the text (filenames) start on a new line you know it is the file that starts on that line.

@okorshenko
Copy link
Contributor

Hi @deadlyw1re. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1380 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@okorshenko okorshenko added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Mar 2, 2018
@Vishrootways
Copy link

How to solve this error in Magento 2.1.8 version? Please help us if anyone know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PieterCappelle PieterCappelle

Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@hostep @magento-team @PieterCappelle @LSERRE @okorshenko @Vishrootways @WalterSmulders @deadlyw1re @magento-engcom-team