Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

980: Added widget.xml file in context generation #983

Merged
merged 3 commits into from
Feb 14, 2022
Merged

980: Added widget.xml file in context generation #983

merged 3 commits into from
Feb 14, 2022

Conversation

doninAtwix
Copy link
Contributor

Description (*)
Added widget.xml file in context generation.
Screenshot 2022-02-14 at 15 52 35
Screenshot 2022-02-14 at 15 51 58
Screenshot 2022-02-14 at 15 56 10

Fixed Issues (if relevant)

  1. Fixes Add a new context dependent Action for the widget.xml file generation #980

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@bohdan-harniuk bohdan-harniuk self-assigned this Feb 14, 2022
@bohdan-harniuk bohdan-harniuk self-requested a review February 14, 2022 14:32
bohdan-harniuk
bohdan-harniuk requested changes Feb 14, 2022
View reviewed changes
Copy link
Collaborator

@bohdan-harniuk bohdan-harniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @doninAtwix!

Great work. Please, take a look at my comment.

resources/fileTemplates/internal/Magento Widget XML.xml.html Outdated
</p>
</font>
</body>
</html>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add a new line here.

@bohdan-harniuk bohdan-harniuk self-requested a review February 14, 2022 19:23
bohdan-harniuk
bohdan-harniuk approved these changes Feb 14, 2022
View reviewed changes
Copy link
Collaborator

@bohdan-harniuk bohdan-harniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bohdan-harniuk bohdan-harniuk merged commit b924a52 into magento:4.3.0-develop Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bohdan-harniuk bohdan-harniuk bohdan-harniuk approved these changes

Assignees

@bohdan-harniuk bohdan-harniuk

Labels
Partner: Atwix partners-contribution Progress: approved Progress: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a new context dependent Action for the widget.xml file generation
2 participants
@doninAtwix @bohdan-harniuk