963: Bug during composer json generation #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Iamwade
commented
Feb 9, 2022
Iamwade
commented
- Fixes Bug during composer json generation if in dependent module version tag is not specified #963
bohdan-harniuk
added
bug
Partner: Atwix
partners-contribution
and removed
Progress: review
labels
bohdan-harniuk
requested changes
Feb 10, 2022
| @@ -184,16 +184,15 @@ private String getDependenciesString(final List dependenciesList) { | |||
| composerJsonFile.getText() | |||
| ); | |||
| final JSONObject jsonObject = (JSONObject) obj; | |||
There was a problem hiding this comment.
jsonObject can be null as well.
| @@ -184,16 +184,15 @@ private String getDependenciesString(final List dependenciesList) { | |||
| composerJsonFile.getText() | |||
| ); | |||
| final JSONObject jsonObject = (JSONObject) obj; | |||
| final String versionJsonElement = jsonObject.get("version").toString(); | |||
| final String versionJsonElement = jsonObject.get("version") == null | |||
| ? "*" : jsonObject.get("version").toString(); | |||
| final String nameJsonElement = jsonObject.get("name").toString(); | |||
There was a problem hiding this comment.
jsonObject.get("name") can be null as well.
| .toString(); | ||
| } | ||
| version = versionJsonElement; | ||
| final int minorVersionSeparator = version.lastIndexOf('.'); |
There was a problem hiding this comment.
We should not do this if there is no version specified.
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: review
Progress: on hold
labels
…plugin into 963-bug-composer-json-generation
m2-community-project
bot
added
Progress: approved
and removed
Progress: changes requested
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.