-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
861: Developed context actions group, added generate routes.xml context action #958
861: Developed context actions group, added generate routes.xml context action #958
Conversation
…plugin into 861-context-dependent-actions
…plugin into 861-context-dependent-actions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @bohdan-harniuk
Thank you for your contribution.
Please check my comment.
Thank you in advance
<td width="100%" valign="top"><font face="verdana" size="-1">Specifies the name of your module | ||
</font> | ||
</td> | ||
</tr> | ||
</table> | ||
</body> | ||
</html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add new line at end of file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Hello, @andrewbess! Thank you for your review! Regards, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @bohdan-harniuk
Thank you for the fast fix
Approved ✔️
Description (*)
Developed abstraction for quick adding new context dependent file generation actions.
To add new file generation action that depends on context:
com.magento.idea.magento2plugin.actions.context.AbstractContextAction
Added new routes.xml generation action.
Conditions to show this action:
Auto-populated variables from the context:
Fixed Issues (if relevant)
Contribution checklist (*)