Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

943: added integration enabled check for custom search scope #944

Conversation

doninAtwix
Copy link
Contributor

Description (*)
Added additional check if the Magento 2 integration is enabled for Magento scopes.

Fixed Issues (if relevant)

  1. Fixes Extend custom search scope (to exclude test files from search) with is integration enabled check #943

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Copy link
Collaborator

@bohdan-harniuk bohdan-harniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @doninAtwix!

Thank you for your work here!

@bohdan-harniuk
Copy link
Collaborator

@doninAtwix, please, add some screenshots of it.

@doninAtwix
Copy link
Contributor Author

Hi @bohdan-harniuk.
After changes you can see next configurations.
Magento integration is disabled:
Screenshot 2022-02-01 at 13 28 12

Magento integration is enabled:
Screenshot 2022-02-01 at 13 29 39

Thank you.

@bohdan-harniuk bohdan-harniuk merged commit 59fbacc into magento:4.3.0-develop Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend custom search scope (to exclude test files from search) with is integration enabled check
2 participants