Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

598: Developed flexible way to add placeholders to dialog window fields that inherited from the JTextComponent #938

Merged
merged 2 commits into from
Jan 26, 2022
Merged

598: Developed flexible way to add placeholders to dialog window fields that inherited from the JTextComponent #938

merged 2 commits into from
Jan 26, 2022

Conversation

Iamwade
Copy link
Collaborator

@Iamwade Iamwade commented Jan 26, 2022 •
edited by bohdan-harniuk
Loading

Description (*)

Developed flexible way to add placeholders to dialog window fields that inherited from the JTextComponent.

  1. Fixes Create documentation #598

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@bohdan-harniuk bohdan-harniuk self-requested a review January 26, 2022 18:36
@bohdan-harniuk bohdan-harniuk self-assigned this Jan 26, 2022
bohdan-harniuk
bohdan-harniuk approved these changes Jan 26, 2022
View reviewed changes
Copy link
Collaborator

@bohdan-harniuk bohdan-harniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Iamwade!

@bohdan-harniuk bohdan-harniuk merged commit 38f451d into magento:4.3.0-develop Jan 26, 2022
@bohdan-harniuk bohdan-harniuk changed the title 598: Added placeholder to dialog window 598: Developed flexible way to add placeholders to a dialog window fields that inherited from the JTextComponent Jan 26, 2022
@bohdan-harniuk bohdan-harniuk changed the title 598: Developed flexible way to add placeholders to a dialog window fields that inherited from the JTextComponent 598: Developed flexible way to add placeholders to dialog window fields that inherited from the JTextComponent Jan 26, 2022
This was referenced Feb 6, 2022
Closed
Closed
This was referenced Feb 18, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bohdan-harniuk bohdan-harniuk bohdan-harniuk approved these changes

Assignees

@bohdan-harniuk bohdan-harniuk

Labels
Advanced Complex Expert Partner: Atwix partners-contribution Progress: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create documentation
2 participants
@Iamwade @bohdan-harniuk