Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

900: Changed realization for function checkDelete using of CheckUtil. #910

Merged
merged 2 commits into from
Jan 13, 2022
Merged

900: Changed realization for function checkDelete using of CheckUtil. #910

merged 2 commits into from
Jan 13, 2022

Conversation

artemii-karkusha
Copy link
Contributor

@artemii-karkusha artemii-karkusha commented Jan 5, 2022

Description (*)

I think we have two variants. We should set this method how deprecated and never use xmlTag.checkDelete() or create another realisation for it. I found service CheckUtil which has realisation checkWritable (similar checkDelete) for PsiElement.

Fixed Issues (if relevant)

  1. Fixes Eliminate LineMarkerXmlTagDecorator#checkDelete usage Eliminate LineMarkerXmlTagDecorator#checkDelete usage #900

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@bohdan-harniuk bohdan-harniuk self-requested a review January 6, 2022 08:11
@bohdan-harniuk bohdan-harniuk self-assigned this Jan 6, 2022
@bohdan-harniuk bohdan-harniuk linked an issue Jan 6, 2022 that may be closed by this pull request
Copy link
Collaborator

@bohdan-harniuk bohdan-harniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @artemii-karkusha!

Thank you for your work here!

@bohdan-harniuk
Copy link
Collaborator

Hello, @artemii-karkusha!

Please, make your branch up to date with the 4.2.2-develop.

@artemii-karkusha
Copy link
Contributor Author

Hello, @bohdan-harniuk
I updated my branch from 4.2.2-develop. Thank you.

@bohdan-harniuk
Copy link
Collaborator

@artemii-karkusha, 👌

@bohdan-harniuk bohdan-harniuk merged commit 0bc74a8 into magento:4.2.2-develop Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eliminate LineMarkerXmlTagDecorator#checkDelete usage
2 participants