Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

698: Add "module" prefix to module name in composer.json #848

Merged
merged 6 commits into from
Dec 16, 2021
Merged

698: Add "module" prefix to module name in composer.json #848

merged 6 commits into from
Dec 16, 2021

Conversation

artemii-karkusha
Copy link
Contributor

Description (*)

According to Magento Devdocs each module should be named with a module prefix in the composer.json. Added logic which adding prefix the module to package-name in composer.json

Issue was reproduced before fixing it:
When we create a new module and set Vendor_Test, it will be named vendor/test.
Screenshot 2021-12-15 at 10 48 36

The result after fixing it:
Screenshot 2021-12-15 at 10 53 32

Fixed Issues (if relevant)

  1. Fixed Add "module" prefix to module name in composer.json #<698>

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

…ateModuleFileWithoutDependencies, testGenerateModuleFile
…GenerateModuleFile. Changed of expectedDirectories.
Copy link
Collaborator

@bohdan-harniuk bohdan-harniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @artemii-karkusha!

Thank you for your contribution.
Please, review small changes.

Thanks, Bohdan.

Copy link
Collaborator

@bohdan-harniuk bohdan-harniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @artemii-karkusha!

Approved ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "module" prefix to module name in composer.json
2 participants