Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

633: Fixed NoSuchElementException when creating new controller #844

Conversation

Iamwade
Copy link
Collaborator

@Iamwade Iamwade commented Dec 13, 2021

Description (*)
Reproduced:
image
steps to reproduce:
You need to specify the wrong type of module (the correct type is ComponentRegistrar::MODULE)
image

Fixed Issues (if relevant)
the error has been fixed. If the module is not in the index, we do not show the dialog window

  1. Fixes [Bug] java.util.NoSuchElementException when creating new controller for module with invalid module type in the registration.php #633

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@bohdan-harniuk
Copy link
Collaborator

Hello, @Iamwade!

I've added additional checks as we discussed before.
Could you please proceed with additional manual testing?

Thanks, Bohdan

@Iamwade
Copy link
Collaborator Author

Iamwade commented Dec 16, 2021

Hello, @bohdan-harniuk
This check was performed and the following result is expected

  1. Type is correct. We saw the dialog window and New -> Module File -> .... Worked correctly
    image

  2. Type is wrong. We haven't seen dialog window New -> Module File
    image

🟢 It's okay.
🟡 The file could not be created for other reasons

Reference Correct
Magento 2 Entity 🟢
Magento 2 Block 🟢
Magento 2 Controller 🟢
Magento 2 Cron Job 🟢
Magento 2 Cron Group 🟢
Magento 2 View Model 🟢
Magento 2 GraphQL Resolver 🟢
Magento 2 CLI Command 🟢
Magento 2 Email Template 🟢
Magento 2 UI Component Grid 🟡
Magento 2 UI Component Form 🟡
Magento 2 Models 🟢
Magento 2 Data Model 🟢
Magento 2 Message Queue 🟢
Magento 2 Declarative Schema XML 🟢

…plugin into 633-no-such-element-exception-when-creating-new-controller
@bohdan-harniuk
Copy link
Collaborator

Hello, @Iamwade!

Thank you for such great work!

Copy link
Collaborator

@bohdan-harniuk bohdan-harniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @Iamwade !

Thank you for your work here!

@bohdan-harniuk
Copy link
Collaborator

bohdan-harniuk commented Dec 17, 2021

@Iamwade, could you please report about found bug?
Since this does not apply to this problem, open a new task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants