Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix-739: Fixed empty psi elements in the plugin inspections #816

Conversation

bohdan-harniuk
Copy link
Collaborator

@bohdan-harniuk bohdan-harniuk commented Nov 30, 2021

Description (*)

Fixed empty psi elements in the plugin inspections.

The bug is reproduced before fixing it:

Screenshot 2021-11-30 at 15 29 18

The result of fixing:

Screenshot 2021-11-30 at 15 47 04

The same issue is found for the PHPStorm inspection:

Screenshot 2021-11-30 at 15 32 02

For clean testing it is should be disabled before testing bugfix:

Screenshot 2021-11-30 at 15 31 29

I've opened an issue in the PHPStorm regarding mentioned PHPStorm inspection:

https://youtrack.jetbrains.com/issue/WI-64186

Fixed Issues (if relevant)

  1. Fixes [Bug] Empty PSI elements must not be passed to createDescriptor (PluginInspection.java:294) #739

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Sorry, something went wrong.

Copy link
Collaborator

@andrewbess andrewbess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bohdan-harniuk
Thank you for your contribution
Approved ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Empty PSI elements must not be passed to createDescriptor (PluginInspection.java:294)
3 participants