Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/765: Fixed stack overflow error for line-marker providers #813

Conversation

bohdan-harniuk
Copy link
Collaborator

Description (*)

Fixed stack overflow error for the next line-marker providers:

  • com.magento.idea.magento2plugin.linemarker.php.PluginLineMarkerProvider
  • com.magento.idea.magento2plugin.linemarker.php.PluginTargetLineMarkerProvider
  • com.magento.idea.magento2plugin.linemarker.php.WebApiLineMarkerProvider

The bug was successfully reproduced by the next steps:

  1. created new class A
  2. created new class B
  3. added plugins for class A
  4. made class A extends class B
  5. made class B extends class A

Screenshot 2021-11-29 at 11 31 44

The results after fixing it:

Screenshot 2021-11-29 at 15 14 34

Screenshot 2021-11-29 at 15 14 49

Fixed Issues (if relevant)

  1. Fixes [Bug] StackOverflowError exception in the PluginLineMarkerProvider #765

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Copy link
Collaborator

@andrewbess andrewbess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bohdan-harniuk
Thank you for your contribution
Approved ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] StackOverflowError exception in the PluginLineMarkerProvider
3 participants