Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically detect version and platform #777

Conversation

Iamwade
Copy link
Collaborator

@Iamwade Iamwade commented Nov 17, 2021

Description (*)
When you open a framework tab, it will automatically start the version checking process.
This will allow to exclude possible situations when Magento 2 version has been updated, but in the settings window it shows the old version.

  1. Fixes Automatically detect version and platform type when opening a setup form in the framework tab. #756

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Copy link
Collaborator

@bohdan-harniuk bohdan-harniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @Iamwade !

Thank you for your efforts!

Copy link
Collaborator

@andrewbess andrewbess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Iamwade
Thank you for your contribution.
Good work

@bohdan-harniuk bohdan-harniuk merged commit 261ec80 into magento:4.2.0-develop Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically detect version and platform type when opening a setup form in the framework tab.
3 participants