UCT-687: Enhanced Magento 2 version resolved #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plugin into incorrect-display-of-magento-2-version
eduard13
requested changes
Nov 10, 2021
| public enum MagentoVersion { | ||
|
|
||
| ENTERPRISE_EDITION("magento/product-enterprise-edition", 1), | ||
| COMMUNITY_EDITION("magento/product-community-edition", 2); |
There was a problem hiding this comment.
Are these composer packages? If yes - how is supposed to work with projects installed via GitHub?
There was a problem hiding this comment.
@eduard13, it was not supported in the previous functional and is not supposed to be supported for now. We need correct version lookup for the UCT version auto-detection. You can create new issue for adding support of dev Magento version resolving, or I'll create issue for that later.
Thanks, Bohdan
m2-community-project
bot
added
Progress: changes requested
Progress: review
and removed
Progress: approved
Progress: changes requested
labels
andrewbess
approved these changes
Nov 10, 2021
There was a problem hiding this comment.
Hello @Iamwade
Thank you for your contribution here.
Great job
eduard13
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Enhanced Magento 2 version resolved.
Changed logic of Magento 2 version resolving.
Previously it looked at composer.json file. It logic is incorrect because composer.json contains current project version but not magento 2 version. More than that version property in composer.json is not required, so it can be absent.
Fixed Issues (if relevant)
Contribution checklist (*)