Entity web api generation #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plugin into entity-web-api-generation
bohdan-harniuk
force-pushed
the
entity-web-api-generation
branch
from
3f89410 to
f636b1e
Compare
m2-community-project
bot
added
Progress: review
and removed
Progress: ready for review
labels
…plugin into entity-web-api-generation
eduard13
requested changes
Jun 24, 2021
| @@ -19,7 +19,7 @@ | |||
| public static final String WEB_API_METHOD_NAME = "execute"; | |||
| private static final String DIRECTORY = "Command"; | |||
| private static final String WEB_API_INTERFACE_NAME_PATTERN = "Delete%entityName%ByIdInterface"; | |||
| private static final String WEB_API_URL_PATTERN = "%entityName%/delete-by-id"; | |||
| private static final String WEB_API_URL_PATTERN = "%entityName%/delete-by-id/:entityId"; | |||
There was a problem hiding this comment.
Let's keep it simpler like /V1/employee/:entityId, since we specify the DELETE method, there is no reason have additional info in route.
There was a problem hiding this comment.
Thank you! I'll fix that in a moment!
There was a problem hiding this comment.
@eduard13, I have done that:
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: review
labels
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
eduard13
added
in testing
QA passed
Medium
Award: test coverage
and removed
in testing
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
What was done:
Contribution checklist (*)