Used a constant in all places where entity id was used as hardcoded value #606
+458
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m2-community-project
bot
added
Progress: review
and removed
Progress: ready for review
labels
bohdan-harniuk
force-pushed
the
entity-web-api-generation
branch
from
b3cd1fd to
e2492fa
Compare
bohdan-harniuk
force-pushed
the
entity-web-api-generation
branch
from
e2492fa to
59ed68d
Compare
…plugin into entity-web-api-generation
eduard13
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
All files generated with the Entity Creator feature and use entity id field were modified to use data transfer object or data transfer object interface constant value instead of hardcoded one. All affected test cases were modified, new test cases added as needed.
Contribution checklist (*)