Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added resource to web API dialog form #595

Merged

Conversation

anzin
Copy link
Contributor

@anzin anzin commented May 26, 2021

Description (*)

I've added all ACL resources to the web API dialog form.

Result:
image

image

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @anzin, thank you for contribution. Can we have a restriction to always select a value from dropdown? Currently, we can enter and submit the form having a wrong ACL entered.
image

Thank you.

@anzin
Copy link
Contributor Author

anzin commented Jun 3, 2021

Hello @eduard13 thank you for your check, I will do a restriction to always select a value from the dropdown.

@eduard13
Copy link
Contributor

Hi @anzin, are you willing to continue the progress on this PR?

Thank you.

@anzin
Copy link
Contributor Author

anzin commented Jun 22, 2021

Hello @eduard13, I've added a restriction to always select a value from the dropdown.

Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants