Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop types inspections inside type tag #582

Conversation

bohdan-harniuk
Copy link
Collaborator

@bohdan-harniuk bohdan-harniuk commented Apr 26, 2021

Description (*)
Developed the Type tag inspections (di.xml file) that detect empty values or invalid values where Type (class, interface, virtual type) values are expected.
Covered those inspections with the test cases.
Improved inspections by exporting validation to concrete validation implementations for reusing them.
Improved inspection declaration by exporting group and displayName attributes to the inspection bundle messages.

Screenshot 2021-04-26 at 16 28 28

Screenshot 2021-04-26 at 16 43 08

Screenshot 2021-04-26 at 16 43 22

Screenshot 2021-04-26 at 16 43 33

Fixed Issues (if relevant)

  1. Fixes Develop type tag inspections #567

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Sorry, something went wrong.

@VitaliyBoyko
Copy link
Contributor

Great job @bohdan-harniuk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Develop type tag inspections
3 participants