Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added reference navigation for observer name #439

Merged
merged 14 commits into from
Mar 15, 2021
Merged

Added reference navigation for observer name #439

merged 14 commits into from
Mar 15, 2021

Conversation

drpayyne
Copy link
Contributor

Description

This PR adds

  • reference navigation for observer name
  • test coverage

Fixed Issues

  1. Fixes Reference navigation for disabled observers #423: Reference navigation for disabled observers

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@coderimus coderimus self-assigned this Dec 22, 2020
@coderimus coderimus self-requested a review December 22, 2020 13:48
@VitaliyBoyko VitaliyBoyko changed the base branch from 3.1.0-develop to 3.2.0-develop February 3, 2021 14:55
@VitaliyBoyko
Copy link
Contributor

Hi @drpayyne

Are you up to proceed with this?

@drpayyne
Copy link
Contributor Author

drpayyne commented Feb 8, 2021

Hi @VitaliyBoyko, yes I believe this still requires a review? I had contacted @coderimus regarding the unrelated test failures but not sure about it. So I'd need help figuring out why these tests are failing. Thanks!

@VitaliyBoyko
Copy link
Contributor

@drpayyne Could you please fix conflicts then?

@drpayyne
Copy link
Contributor Author

drpayyne commented Feb 8, 2021

Done, @VitaliyBoyko!

@VitaliyBoyko
Copy link
Contributor

VitaliyBoyko commented Feb 8, 2021 •
edited
Loading

So only static tests are falling. Could you please fix them?

Vitaliy Boyko added 4 commits March 15, 2021 11:11
Merge branch '3.2.0-develop' of github.com:magento/magento2-phpstorm-…
3aa6b63 
…plugin into issue-423

� Conflicts:
�	resources/phpstorm.meta.php/di-autocomplete.php
�	tests/com/magento/idea/magento2plugin/reference/xml/ObserverReferenceRegistrarTest.java
Removed redundant annotation
08f3c1b
Removed singleton
3f8a8e7
Static fixes
94cac05
coderimus
coderimus approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@coderimus coderimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drpayyne thank you for the implementation. Approved!

@coderimus coderimus merged commit 4f31dc3 into magento:3.2.0-develop Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderimus coderimus coderimus approved these changes

Assignees

@coderimus coderimus

Labels
Award: test coverage Partner: EY partners-contribution Progress: approved Progress: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reference navigation for disabled observers
4 participants
@drpayyne @VitaliyBoyko @coderimus @magento-engcom-team