Skip to content

Fixed model generation with same names #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 23, 2020
Merged

Fixed model generation with same names #438

merged 7 commits into from
Dec 23, 2020

Conversation

drpayyne
Copy link
Contributor

Description

Fixed generation of models with same model/resource model name.

Fixed Issues

  1. Fixes The added model and collection classes contain duplicate names of the imported classes #437: The added model and collection classes contain duplicate names of the imported classes

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@VitaliyBoyko VitaliyBoyko self-assigned this Dec 22, 2020
@VitaliyBoyko VitaliyBoyko self-requested a review December 22, 2020 11:16
eduard13
eduard13 requested changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix, could you please check my comments below?

@eduard13 eduard13 added the Easy label Dec 22, 2020
@VitaliyBoyko VitaliyBoyko removed their request for review December 22, 2020 18:47
@drpayyne
Copy link
Contributor Author

Hi @eduard13, thanks for catching my typos! I've implemented your suggested changes. Please review again.

@drpayyne drpayyne requested a review from eduard13 December 23, 2020 05:13
eduard13
eduard13 approved these changes Dec 23, 2020
View reviewed changes
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

@VitaliyBoyko VitaliyBoyko merged commit fee9468 into magento:3.0.3-develop Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduard13 eduard13 eduard13 approved these changes

Assignees

@eduard13 eduard13

@VitaliyBoyko VitaliyBoyko

Labels
Easy Partner: EY partners-contribution Progress: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drpayyne @eduard13 @VitaliyBoyko @magento-engcom-team