Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data model generation #399

Merged
merged 17 commits into from
Nov 25, 2020
Merged

Data model generation #399

merged 17 commits into from
Nov 25, 2020

Conversation

drpayyne
Copy link
Contributor

@drpayyne drpayyne commented Nov 20, 2020 •
edited
Loading

Description

Added generator for Magento 2 Data Models

  • Generates interface with getters and setters
  • Generates model implementing generated interface with its methods utilizing Magento\Framework\DataObject to store data
  • Generates a preference in the di.xml for the interface -> implementation mapping
  • Covers with tests

Todo

  • di.xml preference generation
  • Tests

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@drpayyne drpayyne marked this pull request as draft November 20, 2020 12:58
@drpayyne drpayyne marked this pull request as ready for review November 20, 2020 17:05
@VitaliyBoyko VitaliyBoyko self-assigned this Nov 21, 2020
@drpayyne drpayyne force-pushed the data-model-generation branch from e597473 to 916620c Compare November 23, 2020 07:24
@drpayyne drpayyne force-pushed the data-model-generation branch from 4390ca8 to 8449220 Compare November 24, 2020 08:09
@VitaliyBoyko VitaliyBoyko merged commit e290833 into magento:2.1.0-develop Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VitaliyBoyko VitaliyBoyko VitaliyBoyko approved these changes

Assignees

@VitaliyBoyko VitaliyBoyko

Labels
Advanced Award: test coverage Expert Partner: EY partners-contribution Progress: approved Progress: done QA passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drpayyne @VitaliyBoyko @magento-engcom-team