Added completion and reference for module names in config.php with tests #374
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
modules
array inconfig.php
assertHasNoReferenceToDirectory
completion/xml/CompletionXmlFixtureTestCase.java
tocompletion/BaseCompletionTestCase.java
to make it extensible and cleaned up code wherever possibleFixed Issues
Questions
ElementPattern
does not work for both completion and reference. Reference seems to work only when usingpsiElement(StringLiteralExpression.class)
and completion seems to work only when using the child of the previously mentioned element,psiElement(PhpTokenTypes.STRING_LITERAL_SINGLE_QUOTE)
. Is there a better way to make this common?Contribution checklist