Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added completion and reference for module names in config.php with tests #374

Merged
merged 4 commits into from
Nov 10, 2020

Conversation

drpayyne
Copy link
Contributor

@drpayyne drpayyne commented Nov 5, 2020

Description

  • Added completion and reference to modules names under the modules array in config.php
  • Added postive/negatives tests for the above
  • Added new test assertion assertHasNoReferenceToDirectory
  • Moved common logic from completion/xml/CompletionXmlFixtureTestCase.java to completion/BaseCompletionTestCase.java to make it extensible and cleaned up code wherever possible

Fixed Issues

Questions

  • The same ElementPattern does not work for both completion and reference. Reference seems to work only when using psiElement(StringLiteralExpression.class) and completion seems to work only when using the child of the previously mentioned element, psiElement(PhpTokenTypes.STRING_LITERAL_SINGLE_QUOTE). Is there a better way to make this common?

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Copy link
Contributor

@coderimus coderimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @drpayyne
Thank you for the relly helpful functionality which makes our work more comfortable. Great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add module names completion and reference in config.php
3 participants