Fixed interface plugin linemarker

[drpayyne]

Description

This PR fixes the missing linemarker for plugins to interface methods

Fixed Issues

1. Plugin linemarkers is missing for interface methods #322: Plugin linemarkers is missing for interface methods

Questions or comments

I have a proposed solution, but if anyone has a better solution, please do let me know. I shall improve it.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with integration/functional tests (if applicable)
• All automated tests passed successfully (all builds are green)

[drpayyne]

Please check the first commit in this PR (ref: a17b6a3) to find my proposed solution. The other commit adds too many static test fixes.

Also, I was thinking if the below code would be a better approach than the one in the above commit. This code would get both classes and interfaces, for the given FQN, instead of just getting interfaces only if classes returned empty. Is there a case where the below code would be required? Just bouncing off ideas, thanks.

for (String targetClassName : targetClassNames) {
    Collection<PhpClass> targets = phpIndex.getClassesByFQN(targetClassName);
    targets.addAll(phpIndex.getInterfacesByFQN(targetClassName));
    results.addAll(targets);
}

[drpayyne]

This PR edits a single line of a file where there are 10s of pre-existing static test failures. I shall fix those failures once my suggested approach is confirmed by a reviewer. Thanks!

[VitaliyBoyko]

@drpayyne I'm fine with the solution. Please proceed.

[drpayyne]

Hi @VitaliyBoyko, could you please advise on how I can fix the remaining static test failures? I'm not sure what's the good approach.

/home/runner/work/magento2-phpstorm-plugin/magento2-phpstorm-plugin/src/com/magento/idea/magento2plugin/linemarker/php/PluginTargetLineMarkerProvider.java:79:	Avoid using implementation types like 'HashMap'; use the interface instead

/home/runner/work/magento2-phpstorm-plugin/magento2-phpstorm-plugin/src/com/magento/idea/magento2plugin/linemarker/php/PluginTargetLineMarkerProvider.java:132:	To avoid mistakes add a comment at the beginning of the TargetClassesCollector constructor if you want a default access modifier

/home/runner/work/magento2-phpstorm-plugin/magento2-phpstorm-plugin/src/com/magento/idea/magento2plugin/linemarker/php/PluginTargetLineMarkerProvider.java:147:	To avoid mistakes add a comment at the beginning of the TargetMethodsCollector constructor if you want a default access modifier

[VitaliyBoyko]

QA passed ✅