Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference for file path declared in XMl/JavaScript are broken #3

Merged
merged 1 commit into from
Jan 5, 2018
Merged

Reference for file path declared in XMl/JavaScript are broken #3

merged 1 commit into from
Jan 5, 2018

Conversation

voleye
Copy link
Contributor

@voleye voleye commented Dec 8, 2017

Steps to Reproduce

  • Go to any xml/javascript file containing file path declaration and try to navigate, for example:
    vendor/magento/module-catalog/view/adminhtml/requirejs-config.js

Actual Result

  • Nothing happens

Actual Result

  • Navigation works properly, you can navigate to appropriate element from xml/javascript file

giabmf11
giabmf11 approved these changes Jan 5, 2018
View reviewed changes
Copy link

@giabmf11 giabmf11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@giabmf11 giabmf11 merged commit 6b6ddc8 into magento:master Jan 5, 2018
@vasilii-b vasilii-b mentioned this pull request Mar 25, 2020
Merged
@vasilii-b vasilii-b mentioned this pull request Apr 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giabmf11 giabmf11 giabmf11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@voleye @giabmf11