Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

82-ui component form generation MVP #281

Merged
merged 12 commits into from
Oct 1, 2020

Conversation

VitaliyBoyko
Copy link
Contributor

@VitaliyBoyko VitaliyBoyko commented Sep 24, 2020

Description (*)
Added UI component form generation action.
Generation includes creating:

  • button classes
  • data provider class
  • controller classes
  • layout
  • routes.xml
  • UI component

image
image

Fixed Issues (if relevant)

  1. Action/Code generation. UI component form generation #82: UI component form

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@VitaliyBoyko VitaliyBoyko marked this pull request as draft September 24, 2020 12:47
@coderimus coderimus self-assigned this Sep 24, 2020
@VitaliyBoyko VitaliyBoyko changed the title [WIP] 89-ui component form generation [WIP] 82-ui component form generation Sep 24, 2020
@VitaliyBoyko VitaliyBoyko marked this pull request as ready for review September 30, 2020 11:40
@VitaliyBoyko VitaliyBoyko changed the title [WIP] 82-ui component form generation 82-ui component form generation MVP Sep 30, 2020
@coderimus
Copy link
Contributor

@VitaliyBoyko thank you for the provided improvement. It provides not only a new feature like an UI component generation but also it saves time for the development workflow. That is a great thing!

I put the next awards because this PR provides a completely new complex feature and it's implementation required a lot of well organized and structured development plus architectural approach. This is also why I put two other achievements.

@VitaliyBoyko VitaliyBoyko merged commit 24f5b57 into 2.0.0-develop Oct 1, 2020
@VitaliyBoyko
Copy link
Contributor Author

Thanks @coderimus !

@VitaliyBoyko VitaliyBoyko deleted the 89-UI-component-form-generation branch October 15, 2020 08:42
@drpayyne drpayyne mentioned this pull request Nov 6, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants