Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1295: Exclude 'ARRAY' property type from the property list because it… #2502

Conversation

vitaliyboykocontributor
Copy link
Contributor

… breaks entity generator

But still keep it in the Data Model generator.

Description (*)

Fixed Issues (if relevant)

  1. Fixes Please add array as type in DataModel properties #1295

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

… breaks entity generator

Added a conditional check to skip the 'ARRAY' property type when populating the property list. This ensures that unwanted types are filtered out, improving functionality and data accuracy.
@VitaliyBoyko VitaliyBoyko merged commit e904de9 into magento:5.4.0-develop Feb 26, 2025
5 checks passed
@VitaliyBoyko VitaliyBoyko deleted the 1295-removed-array-type-from-entity-generator branch February 26, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Please add array as type in DataModel properties
3 participants