2490 remove usages of scheduled for removal api #2495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor code to remove usage of the SlowOperations API for resolving references and retrieving data, improving performance and aligning with the latest IntelliJ guidelines. Additionally, deprecated methods and hardcoded Magento directory prompts were removed, and notification handling was updated to use modern APIs.
…usages-of-scheduled-for-removal-API
This release updates the plugin to version 2025.0.1 and includes a fix for compatibility with the 2025.* PhpStorm build range. Minor adjustments to plugin documentation and formatting were also applied for improved clarity and presentation.
Corrected the changelog to clarify compatibility with PhpStorm/IntelliJ 2025.* builds. This ensures the documentation accurately reflects the scope of the fix.
Streamlined retrieval of module names and their associated files by consolidating logic into `FileBasedIndex` queries. Removed deprecated utility method usages, reducing unnecessary complexity and improving maintainability.
Updated dialog action methods from `onOK` to `onWriteActionOK` and ensured execution through a centralized `executeOnOk` method. This improves thread safety by enforcing operations within the IDE's `WriteAction` context. Also added handling for exceptions during execution and support for dumb mode in `NewModuleFileGroup`.
Acknowledgment text for sponsors was added to the README file. This change highlights support from Lucas van Staden and Ivan Chepurnyi. It enhances transparency and gratitude towards contributors.
Updated constructors in `NewSetupDataPatchDialog` and `NewLayoutTemplateDialog` with detailed Javadoc comments. These updates provide clarity on their purpose, parameters, and behaviors, improving code readability and maintainability.
Removed redundant and overly verbose Javadoc comments in `NewSetupDataPatchDialog` and `NewLayoutTemplateDialog`. Simplified and clarified descriptions to enhance readability and maintain consistency.
Replaced inline lambdas with method references for cleaner code, added `NOPMD` annotations to suppress redundant warnings, and improved transient field usage for serialization safety. Extracted logic for module name retrieval into a reusable method for modularity and reduced code duplication.
Reused `FileBasedIndex` instance to enhance readability and performance by avoiding redundant calls. Also, fixed import order to follow code style conventions.
Added //NOPMD comments to suppress PMD warnings on JLabel fields. Updated method signatures to use final for consistency and improved readability.
VitaliyBoyko
approved these changes
Feb 22, 2025
VitaliyBoyko
deleted the
2490-Remove-usages-of-scheduled-for-removal-API
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Fixed Issues (if relevant)
Questions or comments
Contribution checklist (*)