1639: Remove SearchGutterIconNavigationHandler and simplify markers #2485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleted the unused `SearchGutterIconNavigationHandler` class and replaced its implementation in `PluginLineMarkerProvider` with direct `NavigationGutterIconBuilder` usage. This simplifies the code and removes redundant complexity.
…failed-Do-not-use-PsiElement-for-popup-model.-See-PsiTargetNavigator
…ng.Throwable-Assertion-failed-Do-not-use-PsiElement-for-popup-model.-See-PsiTargetNavigator
Addressed an assertion failure related to improper `PsiElement` usage for popup models in `PluginLineMarkerProvider`. Made the `NavigationGutterIconBuilder` instance immutable by declaring it as `final`, enhancing code safety and readability. Updated the changelog for relevant changes.
…sertion-failed-Do-not-use-PsiElement-for-popup-model.-See-PsiTargetNavigator' into 1639-java.lang.Throwable-Assertion-failed-Do-not-use-PsiElement-for-popup-model.-See-PsiTargetNavigator
Ensured line markers are correctly created by targeting the `ASTNode` of type `IDENTIFIER` for `PsiElement`. This change prevents potential errors and improves precision in line marker rendering. Enhanced the stability and correctness of the `PluginLineMarkerProvider`.
VitaliyBoyko
approved these changes
Feb 15, 2025
magento-ct-gh-projects-svc
added
Progress: approved
and removed
Progress: review
labels
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleted the unused
SearchGutterIconNavigationHandlerclass and replaced its implementation inPluginLineMarkerProviderwith directNavigationGutterIconBuilderusage. This simplifies the code and removes redundant complexity.Contribution checklist (*)