Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused code #2

Merged
merged 1 commit into from
Jan 5, 2018
Merged

Remove unused code #2

merged 1 commit into from
Jan 5, 2018

Conversation

voleye
Copy link
Contributor

@voleye voleye commented Dec 8, 2017

Remove unused code

  • Remove Web api inspection, Object manager inspection (decided to move this responsibility to PHPCS)
  • Remove commented lines in plugin.xml

giabmf11
giabmf11 approved these changes Dec 20, 2017
View reviewed changes
Copy link

@giabmf11 giabmf11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. We have change control. No need for commented out code.

@giabmf11 giabmf11 merged commit 348aeca into magento:master Jan 5, 2018
@phpWebStudio phpWebStudio mentioned this pull request Apr 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giabmf11 giabmf11 giabmf11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@voleye @giabmf11