Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with creating observer #163

Merged
merged 4 commits into from
Apr 17, 2020
Merged

Fix issue with creating observer #163

merged 4 commits into from
Apr 17, 2020

Conversation

AndreyChorniy
Copy link

Description (*)

Fixed issue for creating observer with _eventManager
FixForObserverCreation

Fixed Issues (if relevant)

  1. Create an Observer action is missing for _eventManager (field with underscore preffix) #150: Create an Observer action is missing for _eventManager (field with underscore preffix)

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages

@VitaliyBoyko VitaliyBoyko self-assigned this Apr 17, 2020
Vitaliy Boyko added 2 commits April 17, 2020 21:31
Fixed approach to define an observer
43a8464
Merge branch 'test-inspection-plugin-duplication' into 1.0.0-develop-…
5fbf6c0 
…adrii

# Conflicts:
#	src/com/magento/idea/magento2plugin/actions/generation/CreateAnObserverAction.java
@VitaliyBoyko
Copy link
Contributor

QA passed ✅
image

@VitaliyBoyko VitaliyBoyko merged commit b20d192 into magento:1.0.0-develop Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VitaliyBoyko VitaliyBoyko VitaliyBoyko approved these changes

Assignees

@VitaliyBoyko VitaliyBoyko

Labels
Easy Expert Partner: Atwix partners-contribution Progress: approved Progress: review QA passed release-1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndreyChorniy @VitaliyBoyko @magento-engcom-team